Link to resolved discussion on merge request diff does not toggle visibility
Summary
When clicking on a link to a resolved comment on the merge request diff, the comment remains hidden (unlike on the the discussion tab).
Steps to reproduce
- resolve discussion on merge request
- open link in new browser tab/window
What is the current bug behavior?
No comment is shown.
For example see: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11170/diffs#note_29237761
What is the expected correct behavior?
Automatically unhide the comment as it happens on the discussion tab.
For example see: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11170#note_29237761
Activity
added diff label
mentioned in issue #28013 (moved)
assigned to @MadLittleMods
mentioned in commit 993c9b0f
mentioned in merge request !11327 (merged)
mentioned in commit 16da7f23
I have a feeling this wasn't a regression since the last release.
Also note the fix in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11327 will not cover linking to a note in a past version that doesn't exist in the current version. It would be neat to include the version in the permalink so we could jump to that version though (future issue).
closed via merge request !11327 (merged)
mentioned in commit 0ec6ff5a
mentioned in commit nick.thomas/gitlab-ee@cc572c43
mentioned in merge request !14785
