Unable to disable all restricted visibility levels
Summary
In the admin panel, under application settings, there's a few quirks with the "restricted visibility levels."
- It appears I cannot uncheck more than one visibility level at a time, upon save it does nothing.
- I can never uncheck the last level, whichever one that happens to be.
Steps to reproduce
- Go to admin panel -> settings -> Restricted visibility levels
- Check off all three options and save
- Try to uncheck all three options and save (should still have all 3 checked on page reload)
- Uncheck a single option and save (should work)
- Uncheck another option and save (should work)
- Uncheck final option and save (should still be checked on page reload)
What is the current bug behavior?
Described above.
What is the expected correct behavior?
Allow me to remove restriction for all visibility levels.
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 10.5.0 Redis Version: 3.2.5 Git Version: 2.11.1 Sidekiq Version:4.2.7GitLab information Version: 9.1.4 Revision: fed799a Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://redacted HTTP Clone URL: https://redacted/some-group/some-project.git SSH Clone URL: git@redacted:some-group/some-project.git Using LDAP: yes Using Omniauth: no
GitLab Shell Version: 5.0.2 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 5.0.2 ? ... OK (5.0.2) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 5/1 ... ok 8/4 ... ok 8/5 ... ok 8/6 ... ok 8/7 ... ok 8/8 ... repository is empty 8/9 ... ok 8/10 ... ok 8/11 ... repository is empty 8/12 ... ok 8/13 ... repository is empty 8/14 ... ok 9/15 ... repository is empty 9/16 ... repository is empty 9/17 ... repository is empty 9/18 ... repository is empty 9/19 ... repository is empty 9/20 ... repository is empty 14/22 ... ok 14/23 ... ok 10/27 ... ok 11/28 ... ok 11/29 ... ok 18/31 ... ok 20/32 ... ok 18/33 ... ok 11/35 ... ok 11/36 ... ok 20/37 ... ok 20/38 ... ok 20/39 ... ok 20/40 ... ok 20/42 ... ok 18/43 ... ok 21/44 ... repository is empty 11/45 ... ok 18/47 ... ok 10/48 ... ok 24/52 ... ok 14/54 ... ok 12/61 ... ok 11/62 ... ok 18/63 ... ok 25/64 ... ok 25/66 ... ok 12/67 ... ok 12/68 ... ok 12/69 ... ok 12/70 ... ok 12/71 ... ok 12/72 ... ok 12/73 ... ok 12/74 ... ok 24/75 ... ok 24/76 ... ok 14/77 ... ok 14/78 ... ok 14/79 ... ok 14/80 ... ok 14/81 ... ok 14/82 ... ok 14/83 ... ok 14/84 ... ok 24/85 ... ok 24/86 ... ok 14/87 ... ok 29/90 ... ok 20/91 ... ok 18/92 ... ok 10/93 ... ok 11/94 ... ok 11/95 ... ok 34/96 ... ok 29/97 ... ok 24/98 ... ok 20/99 ... ok 20/100 ... ok 24/101 ... ok 24/102 ... ok 20/103 ... ok 24/105 ... ok 29/107 ... ok 14/108 ... ok 12/109 ... ok 18/110 ... ok 20/111 ... ok 20/112 ... ok 12/113 ... ok 20/114 ... ok 29/115 ... ok 18/116 ... ok 30/117 ... ok 37/118 ... ok 14/119 ... ok 29/121 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
Server: redacted LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) redacted
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config outdated? ... no Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory setup correctly? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) projects have namespace: ... 5/1 ... yes 8/4 ... yes 8/5 ... yes 8/6 ... yes 8/7 ... yes 8/8 ... yes 8/9 ... yes 8/10 ... yes 8/11 ... yes 8/12 ... yes 8/13 ... yes 8/14 ... yes 9/15 ... yes 9/16 ... yes 9/17 ... yes 9/18 ... yes 9/19 ... yes 9/20 ... yes 14/22 ... yes 14/23 ... yes 10/27 ... yes 11/28 ... yes 11/29 ... yes 18/31 ... yes 20/32 ... yes 18/33 ... yes 11/35 ... yes 11/36 ... yes 20/37 ... yes 20/38 ... yes 20/39 ... yes 20/40 ... yes 20/42 ... yes 18/43 ... yes 21/44 ... yes 11/45 ... yes 18/47 ... yes 10/48 ... yes 24/52 ... yes 14/54 ... yes 12/61 ... yes 11/62 ... yes 18/63 ... yes 25/64 ... yes 25/66 ... yes 12/67 ... yes 12/68 ... yes 12/69 ... yes 12/70 ... yes 12/71 ... yes 12/72 ... yes 12/73 ... yes 12/74 ... yes 24/75 ... yes 24/76 ... yes 14/77 ... yes 14/78 ... yes 14/79 ... yes 14/80 ... yes 14/81 ... yes 14/82 ... yes 14/83 ... yes 14/84 ... yes 24/85 ... yes 24/86 ... yes 14/87 ... yes 29/90 ... yes 20/91 ... yes 18/92 ... yes 10/93 ... yes 11/94 ... yes 11/95 ... yes 34/96 ... yes 29/97 ... yes 24/98 ... yes 20/99 ... yes 20/100 ... yes 24/101 ... yes 24/102 ... yes 20/103 ... yes 24/105 ... yes 29/107 ... yes 14/108 ... yes 12/109 ... yes 18/110 ... yes 20/111 ... yes 20/112 ... yes 12/113 ... yes 20/114 ... yes 29/115 ... yes 18/116 ... yes 30/117 ... yes 37/118 ... yes 14/119 ... yes 29/121 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.1.0 ? ... yes (2.3.3) Your git bin path is "/opt/gitlab/embedded/bin/git" Git version >= 2.7.3 ? ... yes (2.11.1) Active users: redacted
Checking GitLab ... Finished