Skip to content
Snippets Groups Projects
New issue look: Off

Code coverage not shown in Merge Request widget for MRs from fork

    • Closed Issue created by Toon Claes @to1ne

    Summary

    Originally reported by @maxraab.

    I just noticed, the code coverage is not shown in the merge request widget (https://gitlab.com/gitlab-org/gitlab-ce/issues/27911#note_26530812). This happens on merge requests from forks to the main repo. The code coverage pattern is exclusively specified in the gitlab-ci.yml not in project settings. (In both repos - fork and main repo). Can you please verify that?

    (Summarize the bug encountered concisely)

    Steps to reproduce

    1. Create project with coverage rule in gitlab-ci.yml
    2. Fork the project
    3. Create a MR toward the orignal project

    What is the current bug behavior?

    Coverage not shown.

    What is the expected correct behavior?

    Coverage should be shown in the Merge Request widget.

    Relevant logs and/or screenshots

    nope

    Output of checks

    Results of GitLab environment info

    Expand for output related to GitLab environment info 
    System information

    System:         Ubuntu 14.04
Current User:   git
Using RVM:      no
Ruby Version:   2.3.3p222
Gem Version:    2.6.6
Bundler Version:1.13.7
Rake Version:   10.5.0
Redis Version:  3.2.5
Git Version:    2.11.1
Sidekiq Version:4.2.7
    

    GitLab information
Version:        9.1.4
Revision:       fed799a
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
URL:            https://git.nsc-gmbh.de
HTTP Clone URL: https://git.nsc-gmbh.de/some-group/some-project.git
SSH Clone URL:  git@git.nsc-gmbh.de:some-group/some-project.git
Using LDAP:     no
Using Omniauth: no
    

    GitLab Shell
Version:        5.0.2
Repository storage paths:
    • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

    Results of GitLab application Check

    Expand for output related to the GitLab application check 
    Checking GitLab Shell ...

    GitLab Shell version >= 5.0.2 ? ... OK (5.0.2)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
6/2 ... ok
10/4 ... ok
6/7 ... ok
10/8 ... ok
10/11 ... ok
10/12 ... ok
10/13 ... ok
6/15 ... ok
10/17 ... ok
10/18 ... ok
10/19 ... ok
10/22 ... ok
10/23 ... ok
6/24 ... ok
4/25 ... ok
5/26 ... ok
5/27 ... ok
3/29 ... ok
3/30 ... ok
7/31 ... ok
3/32 ... ok
4/33 ... ok
7/34 ... ok
7/35 ... ok
6/36 ... ok
3/37 ... ok
3/38 ... ok
3/39 ... ok
6/40 ... ok
6/42 ... ok
4/43 ... ok
6/45 ... ok
6/48 ... ok
6/49 ... ok
6/50 ... ok
6/51 ... ok
3/53 ... ok
6/54 ... ok
4/55 ... ok
10/56 ... ok
6/57 ... ok
3/58 ... ok
5/59 ... ok
6/60 ... ok
10/61 ... ok
10/63 ... ok
6/64 ... ok
15/65 ... ok
10/66 ... ok
6/67 ... ok
5/68 ... ok
3/69 ... ok
6/70 ... ok
3/71 ... ok
3/72 ... ok
5/73 ... ok
3/74 ... ok
10/75 ... ok
3/76 ... ok
6/77 ... ok
3/78 ... ok
10/79 ... ok
3/80 ... ok
6/81 ... ok
6/82 ... ok
3/83 ... ok
3/84 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
    

    Checking GitLab Shell ... Finished
    

    Checking Sidekiq ...
    

    Running? ... yes
Number of Sidekiq processes ... 1
    

    Checking Sidekiq ... Finished
    

    Checking Reply by email ...
    

    Reply by email is disabled in config/gitlab.yml
    

    Checking Reply by email ... Finished
    

    Checking LDAP ...
    

    LDAP is disabled in config/gitlab.yml
    

    Checking LDAP ... Finished
    

    Checking GitLab ...
    

    Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... no
Try fixing it:
sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads
sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} ;
sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} ;
For more information see:
doc/install/installation.md in section "GitLab"
Please fix the error above and rerun the checks.
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
6/2 ... yes
10/4 ... yes
6/7 ... yes
10/8 ... yes
10/11 ... yes
10/12 ... yes
10/13 ... yes
6/15 ... yes
10/17 ... yes
10/18 ... yes
10/19 ... yes
10/22 ... yes
10/23 ... yes
6/24 ... yes
4/25 ... yes
5/26 ... yes
5/27 ... yes
3/29 ... yes
3/30 ... yes
7/31 ... yes
3/32 ... yes
4/33 ... yes
7/34 ... yes
7/35 ... yes
6/36 ... yes
3/37 ... yes
3/38 ... yes
3/39 ... yes
6/40 ... yes
6/42 ... yes
4/43 ... yes
6/45 ... yes
6/48 ... yes
6/49 ... yes
6/50 ... yes
6/51 ... yes
3/53 ... yes
6/54 ... yes
4/55 ... yes
10/56 ... yes
6/57 ... yes
3/58 ... yes
5/59 ... yes
6/60 ... yes
10/61 ... yes
10/63 ... yes
6/64 ... yes
15/65 ... yes
10/66 ... yes
6/67 ... yes
5/68 ... yes
3/69 ... yes
6/70 ... yes
3/71 ... yes
3/72 ... yes
5/73 ... yes
3/74 ... yes
10/75 ... yes
3/76 ... yes
6/77 ... yes
3/78 ... yes
10/79 ... yes
3/80 ... yes
6/81 ... yes
6/82 ... yes
3/83 ... yes
3/84 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.11.1)
Active users: 12
    

    Checking GitLab ... Finished
    ### Possible fixes

    Not known yet.

    Related issues

    gitlab-org/gitlab-ce#27911

    Edited by Toon Claes

    Designs

    Child items ...

    • Activity

    • Toon Claes mentioned in issue #27911 (closed)

      mentioned in issue #27911 (closed)

    • Toon Claes
      Toon Claes @to1ne ·
      Author Developer

      @maxraab Thank you for reporting this issue.

      But could you provide some more details:

      • Does it happen on GitLab.com?
        • If so, is it a public project you can link to?
      • Or which version of GitLab are you using?
    • username-removed-289790
      username-removed-289790 @maxraab ·
      Contributor

      @to1ne I don't have projects and rights to reproduce it on GitLab.com but here are some information about our installation:

      Results of GitLab environment info

      Expand for output related to GitLab environment info 
      System information

      System:         Ubuntu 14.04
Current User:   git
Using RVM:      no
Ruby Version:   2.3.3p222
Gem Version:    2.6.6
Bundler Version:1.13.7
Rake Version:   10.5.0
Redis Version:  3.2.5
Git Version:    2.11.1
Sidekiq Version:4.2.7
      

      GitLab information
Version:        9.1.4
Revision:       fed799a
Directory:      /opt/gitlab/embedded/service/gitlab-rails
DB Adapter:     postgresql
URL:            https://git.nsc-gmbh.de
HTTP Clone URL: https://git.nsc-gmbh.de/some-group/some-project.git
SSH Clone URL:  git@git.nsc-gmbh.de:some-group/some-project.git
Using LDAP:     no
Using Omniauth: no
      

      GitLab Shell
Version:        5.0.2
Repository storage paths:
      • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

      Results of GitLab application Check

      Expand for output related to the GitLab application check 
      Checking GitLab Shell ...

      GitLab Shell version >= 5.0.2 ? ... OK (5.0.2)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
6/2 ... ok
10/4 ... ok
6/7 ... ok
10/8 ... ok
10/11 ... ok
10/12 ... ok
10/13 ... ok
6/15 ... ok
10/17 ... ok
10/18 ... ok
10/19 ... ok
10/22 ... ok
10/23 ... ok
6/24 ... ok
4/25 ... ok
5/26 ... ok
5/27 ... ok
3/29 ... ok
3/30 ... ok
7/31 ... ok
3/32 ... ok
4/33 ... ok
7/34 ... ok
7/35 ... ok
6/36 ... ok
3/37 ... ok
3/38 ... ok
3/39 ... ok
6/40 ... ok
6/42 ... ok
4/43 ... ok
6/45 ... ok
6/48 ... ok
6/49 ... ok
6/50 ... ok
6/51 ... ok
3/53 ... ok
6/54 ... ok
4/55 ... ok
10/56 ... ok
6/57 ... ok
3/58 ... ok
5/59 ... ok
6/60 ... ok
10/61 ... ok
10/63 ... ok
6/64 ... ok
15/65 ... ok
10/66 ... ok
6/67 ... ok
5/68 ... ok
3/69 ... ok
6/70 ... ok
3/71 ... ok
3/72 ... ok
5/73 ... ok
3/74 ... ok
10/75 ... ok
3/76 ... ok
6/77 ... ok
3/78 ... ok
10/79 ... ok
3/80 ... ok
6/81 ... ok
6/82 ... ok
3/83 ... ok
3/84 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
      

      Checking GitLab Shell ... Finished
      

      Checking Sidekiq ...
      

      Running? ... yes
Number of Sidekiq processes ... 1
      

      Checking Sidekiq ... Finished
      

      Checking Reply by email ...
      

      Reply by email is disabled in config/gitlab.yml
      

      Checking Reply by email ... Finished
      

      Checking LDAP ...
      

      LDAP is disabled in config/gitlab.yml
      

      Checking LDAP ... Finished
      

      Checking GitLab ...
      

      Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... no
Try fixing it:
sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads
sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} ;
sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} ;
For more information see:
doc/install/installation.md in section "GitLab"
Please fix the error above and rerun the checks.
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
6/2 ... yes
10/4 ... yes
6/7 ... yes
10/8 ... yes
10/11 ... yes
10/12 ... yes
10/13 ... yes
6/15 ... yes
10/17 ... yes
10/18 ... yes
10/19 ... yes
10/22 ... yes
10/23 ... yes
6/24 ... yes
4/25 ... yes
5/26 ... yes
5/27 ... yes
3/29 ... yes
3/30 ... yes
7/31 ... yes
3/32 ... yes
4/33 ... yes
7/34 ... yes
7/35 ... yes
6/36 ... yes
3/37 ... yes
3/38 ... yes
3/39 ... yes
6/40 ... yes
6/42 ... yes
4/43 ... yes
6/45 ... yes
6/48 ... yes
6/49 ... yes
6/50 ... yes
6/51 ... yes
3/53 ... yes
6/54 ... yes
4/55 ... yes
10/56 ... yes
6/57 ... yes
3/58 ... yes
5/59 ... yes
6/60 ... yes
10/61 ... yes
10/63 ... yes
6/64 ... yes
15/65 ... yes
10/66 ... yes
6/67 ... yes
5/68 ... yes
3/69 ... yes
6/70 ... yes
3/71 ... yes
3/72 ... yes
5/73 ... yes
3/74 ... yes
10/75 ... yes
3/76 ... yes
6/77 ... yes
3/78 ... yes
10/79 ... yes
3/80 ... yes
6/81 ... yes
6/82 ... yes
3/83 ... yes
3/84 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.11.1)
Active users: 12
      

      Checking GitLab ... Finished
      Edited by username-removed-289790
    • Toon Claes changed the description

      changed the description

    • Toon Claes
      Toon Claes @to1ne ·
      Author Developer

      @fatihacet It is happening on 9.1.4, could you please have a look if this still would happen on 9.2?

    • username-removed-289790
      username-removed-289790 @maxraab ·
      Contributor

      @to1ne I've updated my last comment. The output was weird.

    • Toon Claes changed the description

      changed the description

    • Oswaldo Ferreir
      Oswaldo Ferreir @oswaldo ·
      Developer

      @to1ne @grzesiek Tried to reproduce it on the new widget, but it seems to work so far.

      The only "cave at" is that we need to make sure the coverage pattern is setup correctly on the fork project.

      Screen_Shot_2017-05-18_at_11.30.19_AM

    • Toon Claes
      Toon Claes @to1ne ·
      Author Developer

      @oswaldo Wow, thanks for looking into this!

      Normally when the coverage pattern in present in the .gitlab-ci.yml of the original project, it would be set up correctly in the forked project too.

    • Oswaldo Ferreir
      Oswaldo Ferreir @oswaldo ·
      Developer

      Interesting @to1ne, I've not tested setting up the pattern on .gitlab-ci.yml, only through:

      Project Settings -> CI/CD -> Test coverage parsing field

    • Toon Claes
      Toon Claes @to1ne ·
      Author Developer

      OK, thanks!

      Let me set this up locally to give it a try!

    • Toon Claes
      Toon Claes @to1ne ·
      Author Developer

      @oswaldo @fatihacet @maxraab I can confirm with the new Merge Request widget, using the coverage setting in the .gitlab-ci.yml the coverage is also correctly shown for forks:

      image

      I'm gonna close this issue now.

    • Toon Claes closed

      closed

    • username-removed-289790
      username-removed-289790 @maxraab ·
      Contributor

      @to1ne What does "new Merge Request widget" mean? Wich GitLab version is shipped with this new widget?

    • Toon Claes
      Toon Claes @to1ne ·
      Author Developer

      @maxraab Ah sorry.

      The Merge Request widget is the box below the Merge Request description. It shows info about CI pipelines, approvals, coverage, ability to merge, etc.

      You can read all the details about the redesign in https://gitlab.com/gitlab-org/gitlab-ce/issues/25424, and it will ship in GitLab 9.2 (planned for May 22, 2017).

    Please register or sign in to reply