line-number anchor lost in sign-in redirect

Summary

Links to a specific line in a file lose their line-number anchor after the user has been redirected to the sign in page.

Steps to reproduce

Take a link to a line in some file contained in a password-protected repo: https://my.gitlab.site/bad/example/blob/master/myfile#L1234 (This exact example does not work, of course. I am not sure how to give an example with a password-protected repo accessible to everybody.)

Steps to reproduce the problem(s):

1. sign out from my.gitlab.site
2. paste link in address bar
3. gitlab redirects to https://my.gitlab.site/users/sign_in#L1234
4. sign in
5. gitlab redirects to myfile, but the line number anchor is lost

What is the current bug behavior?

• in step 3 the anchor is used in the sign in page, where it is useless
• in step 5 the anchor is lost after the sign in is completed

What is the expected correct behavior?

• in step 3 the anchor is stored as redirect-after login target, but not used on the sign-in page itself
• in step 5 the anchor is included in the redirect

Results of GitLab environment info

Sorry, I cannot give more details than that the site with the problem uses GitLab Community Edition 9.1.4 fed799ae and ldap login.

@alexander-buerger-met-no @markglenfletcher I have reproduced this behavior with 9.4.3. I'll need some label guidance here

It's reproducible by opening the following link to a file in an internal project here on GitLab.com in an incognito window and then signing in:

• https://gitlab.com/issue-reproduce/line-numbers-lost/blob/master/test.rb#L7

added bug frontend reproduced on GitLab.com labels

Opening this bug for a Community Contribution to fix

added Accepting Merge Requests label

mentioned in issue jamesmundia/levelup17#7 (closed)

moved to gitlab#9980

Hey!

GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current gitlab-ce repository will become a read-only mirror, without any proprietary code. All development is moved to the current gitlab-ee repository, which we will rename to just gitlab in the coming weeks. As part of this migration, issues will be moved to the current gitlab-ee project.

If you have any questions about all of this, please ask them in our dedicated FAQ issue.

https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

You can also find more information here:

• https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
• https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/

Frequently Asked Questions

For an up to date list of questions and answers, please take a look at https://gitlab.com/gitlab-org/gitlab-ee/issues/13855

What will we do with the repository names?

https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.

Why rename gitlab-ce to gitlab-foss?

Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear

I created a merge requests for CE, and this got closed. What do I need to do?

You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.

How does the licensing work in this new setup?

Everything in the ee/ directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in the ee/ directory, the process of contributing changes is the same as when using the gitlab-ce repository.

Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?

No. Merge requests submitted to this project will be closed automatically.

Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?

Yes.

How will this affect users of GitLab CE using Omnibus?

No changes will be necessary, as the packages built remain the same.

How will this affect users of GitLab CE that build from source?

Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.

Where can I see a timeline of the remaining steps?

https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?

Yes, these changes will be synced to gitlab-foss automatically, several times per day.

locked this issue