Labels should be visible in milestone view

Will give much better overview of milestone.

Is a bit of a challenge in terms of UX / UI.

Examples: trello, pivotaltracker.

cc @dzaporozhets @creamzy @skyruler

@JobV could you please clarify what do you mean.

Is it like percentage / number of a specific label (in our case it's gonna be Unlabelled most of the time), or should we group the labels into something like Support/DevOps/Backend, etc , which is also kind of complicated. What do you want to achieve in the end?

@creamzy on this view:

https://gitlab.com/gitlab-org/gitlab-ce/milestones/16

I want to be able to quickly see which things are promised (label 'promised'), which are labeled 'interaction'.

I think over time, most issue will have at least one label, possibly more.

Grouping would be cool, but at this point all I want to be able to see how many of X and how many Y labelled issue are still in state Z.

Trello does this by only showing the label color, which is an elegant solution:

Love to hear your thoughts.

Added ~19492 label

Reassigned to @creamzy

@JobV please check the direction , what information do you think should be useful to show here as well? I have my own wish to show time elapsed as extra data on the process

I am in the process of UI update and cleanup based on the current styles, but it would be useful to get your overview from a business side.

@JobV any extra thoughts on this one? Do you also want to see labels in the lists on the issue tab?

Mockup with UI updates in process

Do you also want to see labels in the lists on the issue tab?

@creamzy yes, that's exactly what I'd like! I can imagine that's hard to realise though. The point is that we can quickly see what type of issues a milestone consists of.

@JobV that is why I offered labels tab in https://gitlab.com/gitlab-org/gitlab-ce/uploads/f2d59af4ef1cbd0dd620b103e63ad7bd/Milestone_view_labels.png

not only overview but also open/ closed data possible

@creamzy yeah that's great, but seeing it in the overview would also be nice, so we can quickly see what type of issues are start / unstarted and finished in what degree.

I'm open to alternative solutions.

@JobV with labels inside

@creamzy YES!!!

Added frontend and removed ~19492 labels

Milestone changed to 8.5

Assignee removed

Added ~122770 label

Added feature proposal label

Added ~123454 label

@creamzy

Updates

Fluid layout

Centered fixed layout

mentioned in issue #6061 (closed)

Love it.

mentioned in issue #11661 (closed)

Reassigned to @rdavila

Related issue #11661 (closed)

This is how it's looking until now:

@rdavila I don't really like bright color for delete btn next to close milestone , can we change it to the same style as Edit?

Also I think we've lost + New issue and Browse issues ?

@creamzy I've a couple of questions regarding some differences in the current design and the proposed one:

Currently on the Issues tab the position of New Issue and Browse Issues is:

For the new design on the Labels tab we have:

I think we should move the positions of the buttons on the Issues tab to reflect the new design, do you agree?

@creamzy looks like the current position makes sense because those buttons change based on the current tab:

Issues tab:

Merge Requests tab:

What do you think about:

@creamzy @JobV these is how it's looking now:

Issues tab

Labels tab

@JobV my question is (as @rdavila has implemented the initial issue) should I create a new issue for UI fetching of milestone view or should we just keep this one and update the description ? There is like not a lot, buttons positioning, bg color for milestone description, redundant area below the tabs.

FWIW You might want to consider what it'll look like if many issues have 5 or 6 (or more) labels each. I know we get up to 7 per issue by the time we are "done done", given our current label categories.

@creamzy I'm showing the action buttons based on the current tab now:

PD: I'm going to fix the markup for the 3 blocks with issues when we have multiple labels.

@creamzy @JobV this is how the Issues tab is looking now:

@rdavila great job! Some minor things:

• label height should be 20px when they are in the issue (like on your last screen and sidebar in the issues/MRs), right now they are too big

• milestone description has white background color, no grey anymore. We used to use it to separate descriptions in MRs/issues/milestones, but no more.

@creamzy thanks for the feedback, here is how it looks now:

Issues tab

Labels tab

Note: The problem with the sidebar is generated from the tool that I use to take the screenshot.

@creamzy I think this issue is fine.

@rdavila maybe when you're done with your implementation, you could hand it off to @jschatz1 to do the finishing touches on the UI?

cc @dzaporozhets

@rdavila please link to merge request and give it to @jschatz1 for final touch

mentioned in merge request !2599 (merged)

@JobV @dzaporozhets thanks, will do that asap.

Reassigned to @jschatz1

@jschatz1 looks like the markup of the milestone detail page has changed a bit in a recent changes, I saw that when I was trying to solve the merge conflict, can you please help me with that too?

Assignee removed

@rdavila can you just put your changes on top of recent master code?

@dzaporozhets sure, working on that.

Reassigned to @jschatz1

I've reassigned this to @jschatz1 so we know someone is working on it.

Status changed to closed by commit de84fa36

mentioned in commit 610a4f91

mentioned in commit de84fa36