I REALLY like the smiley faces. You packed so much personality into those!
I think you may have the wrong 'todo-done' for the current icon.
At first I wasn't sure about the thickness, they still feel very similar to the font-awesome icons in that regard. Then I compared these new icons with the illustrations and I can see the parity you are going for.
Since we are moving to straight svg versus icon fonts, we are not bound to just one color. Maybe there is an opportunity to add some personality through slight color variation.
@sarrahvesselov wouldn't multiple colors per icon make changing the color via CSS more difficult? It's super easy to change the fill when they're one color.
Most icons are pretty small and I'm not sure multiple colors would be worth the extra dev trouble.
@tauriedavis no, I have not found it to be more difficult at all, it just uses the fill property in the css. Classes applied to the path take care of the color, here is an example. I am talking about 4 colors maximum for the icon's static and active state. Four classes take care of it all.
Just a thought for adding more personality to our interface with little effort. Icons are small but add up across the application in terms of weight and presence.
Yeah, totally understand the technical part. I just meant it's more code and colors to manage. But if it's worth it, cool. I'll leave that up to you and Hazel!
I worry about the smiley's though, as the mouth is i think to small. I rather go for a bigger mouth, which is instantly recognisable without squinting, as we have some animation going. the placement of the mouth makes it very adorable though, so in that sense
In order to gauge visual weight, i think you should provide a grid view of all icons :) wdyt?
color variation sounds cool to me, although i would suggest a focus on "slight color variation", as to not confuse with emoticons
@dimitrieh@blackst0ne Thanks for bringing up this question! I think the icon for RSS will not be changed since it's a different action from the Subscribe action on the issue sidebar.
Discussion:
Maybe when mousing over these 3 icons, we can have them has the background color?
@hazelyang do the notifications need to be in “3D”? They have a small rounding that gives them a bit of perspective, and the other icons don't have that. Maybe you have a rationale for this
@pedroms Thanks for mentioning this. I just did that intuitively. But I think they should be consistent with others icons. Will update these two icons in the description.
GitLab is moving all development for both GitLab Community Edition
and Enterprise Edition into a single codebase. The current
gitlab-ce repository will become a read-only mirror, without any
proprietary code. All development is moved to the current
gitlab-ee repository, which we will rename to just gitlab in the
coming weeks. As part of this migration, issues will be moved to the
current gitlab-ee project.
If you have any questions about all of this, please ask them in our
dedicated FAQ issue.
Using "gitlab" and "gitlab-ce" would be confusing, so we decided to
rename gitlab-ce to gitlab-foss to make the purpose of this FOSS
repository more clear
I created a merge requests for CE, and this got closed. What do I
need to do?
Everything in the ee/ directory is proprietary. Everything else is
free and open source software. If your merge request does not change
anything in the ee/ directory, the process of contributing changes
is the same as when using the gitlab-ce repository.
Will you accept merge requests on the gitlab-ce/gitlab-foss project
after it has been renamed?
No. Merge requests submitted to this project will be closed automatically.
Will I still be able to view old issues and merge requests in
gitlab-ce/gitlab-foss?
Yes.
How will this affect users of GitLab CE using Omnibus?
No changes will be necessary, as the packages built remain the same.
How will this affect users of GitLab CE that build from source?
Once the project has been renamed, you will need to change your Git
remotes to use this new URL. GitLab will take care of redirecting Git
operations so there is no hard deadline, but we recommend doing this
as soon as the projects have been renamed.
Where can I see a timeline of the remaining steps?