Ensure all calls to `git` use the `bin_path` configuration
- Zendesk ticket: https://gitlab.zendesk.com/agent/tickets/11035
- GitLab version: 8.1
Expected behavior
All calls in GitLab should use the Git bin_path
to ensure the right binary is called.
Observed behavior
There are quite a few locations where only git
is used instead of the full bin_path
. This can lead to strange issues where different versions of git
are used for different operations. Search for %W(git
in the project to see all the locations. There might even be more that aren't using the %W(git
pattern.
Next steps
Go through and change at least all of the places that use %W(git
to use the bin_path
configuration.
Proper usage should be something like %W(#{Gitlab.config.git.bin_path}
cc/ @rspeicher