Email matching for commits should be case insensitive

I have a user whose profile email is all in lower case, but commits with an upper-case letter in their email. Gitlab doesn't match the commit message to the user's profile, and he is unable to add the different casing as an alias because the address is "already in use."

I believe that the fallback name-matching for commits is case-sensitive as well, and probably should not be.

Are you using SSH keys and which version of GitLab?

Yes, the user is using an SSH key; GitLab 6.9.2 GitLab Shell 1.9.5

I'd guess that it has to do with find_for_commit using a case-sensitive search in models/user.rb, but I don't know enough ruby to help beyond that :)

I had the same thought, but I have checked tried it on my own and it works for me. It seems that it matches the user via SSH key.

Or where do you think is the mapping wrong? On which page? Perhaps I have looked on the wrong one.

I just reproduced it here: https://gitlab.com/sonicsnes/casetest/commits/master

Both commits used the same email address, but the second one used a different case and different name. The email match failed, so it matched against some other user named "Mike" who isn't me. Notice the link destination for the commit names.

I can't reproduce it either. Which database are you using?

Can you try to add .downcase on line 198 in models/user.rb:

User.joins(:emails).where(emails: { email: email.downcase }).first ||

Restart your GitLab and try again.

Yep, that works fine for aliases (as long as we are assuming that emails are always stored in lowercase in the database).

Ultimately, all three lines should probably be changed along the lines of:

      User.where(email: email.downcase).first ||
        User.joins(:emails).where(emails: { email: email.downcase }).first ||
        User.where("lower(name) = ?", name.downcase).first

** Regarding your reproduction, you have to ensure that you are committing with a different name as well -- otherwise the system will match your name rather than your email. I'm using postgre, but the issue also occurs on gitlab.com (as noted in my last comment).

Yes I have changed my name, too.

Oh I am sorry, I made a mistake with the line to edit, I meant 197, 198 is for aliases.
And yes emails are always stored as lower case, I have checked that.

Perhaps this issue is related to postgre, I will try to setup an instance with integrated postgre and try again. I am using MySQL as database backend.

Okay I can reproduce it with postgre, so there is a need for a change.

In general I am thinking about changing the storage of commit information with always lower case instead of changing the way to search.

Status changed to closed

This should be fixed in the current version of gitlab so I'll close this.
If you're still experiencing this issue, please feel free to reopen it.

We are having this issue in "GitLab Community Edition 8.2.2 08fae2fd".

The email in commits is in mixed-case, the email in user's profile is shown in lower-case. The email originates from Active Directory, in case that matters. In AD it was originally stored as mixed-case, and the commits were not matched to the user. We tried to change the user's email in AD to lower-case and relogin him, but the commits are still not matched.

Can you please look into this issue again?

Status changed to reopened

We are also having the same issue. All users are setup using lower case, but sometimes they have there local settings with mixed case. When this happens the user is not matched to the gitlab user. Simply changing there local settings to lower case fixes this (Until the next time they muck around with their settings)

mentioned in issue #4087 (closed)

Milestone changed to 8.4

Added ~12980 label

Fixed by https://gitlab.com/gitlab-org/gitlab-ce/commit/7e8fc4822758057ed8a2239659cdd8f49099613d

Status changed to closed