Deploy keys tests are failing silently
Deploy keys tests are failing silently. When vue throws warnings, the tests won't ran but they will also not fail.
We need to fix:
Deploy keys app component
hasKeys returns true when there are keys
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
Deploy keys key
enabled key
✔ renders the keys title
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
✔ renders human friendly formatted created date
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
✔ shows edit button
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
✔ shows remove button
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
✔ shows write access text when key has write access
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
public keys
✔ shows edit button
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
✔ shows enable button
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
✔ shows disable button when key is enabled
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
Deploy keys panel
✔ renders the title with keys count
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
✔ renders list of keys
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
✔ renders help box if keys are empty
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Missing required prop: "endpoint"
(found in <Root>)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
ERROR: '[Vue warn]: Invalid prop: type check failed for prop "endpoint". Expected String, got Undefined.
(found in <Key> at /builds/gitlab-org/gitlab-ce/app/assets/javascripts/deploy_keys/components/key.vue)'
According to @jschatz1 this needs to be handled as a regression