Mailroom not starting after 8.1.3 upgrade
On Ubuntu 14.04 I've just upgraded from gitlab-ce 8.1.0-ce.1 to 8.1.3-ce.0. I noticed a ruby processes using a lot of CPU as the git user. Checking I saw it was (respawning):
ruby /opt/gitlab/embedded/service/gem/ruby/2.1.0/bin/mail_room -c /var/opt/gitlab/gitlab-rails/etc/mail_room.yml
And checking the log:
2015-11-06_14:55:27.72124 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/cli.rb:52:in `start'
2015-11-06_14:55:27.72125 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/bin/mail_room:5:in `<top (required)>'
2015-11-06_14:55:27.72127 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/bin/mail_room:23:in `load'
2015-11-06_14:55:27.72128 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/bin/mail_room:23:in `<main>'
2015-11-06_14:55:27.82321 Runit: starting mail_room
2015-11-06_14:55:39.14673 /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:1158:in `get_tagged_response': TLS is already active. (Net::IMAP::BadResponseError)
2015-11-06_14:55:39.14676 from /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:1210:in `block in send_command'
2015-11-06_14:55:39.14676 from /opt/gitlab/embedded/lib/ruby/2.1.0/monitor.rb:211:in `mon_synchronize'
2015-11-06_14:55:39.14676 from /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:1192:in `send_command'
2015-11-06_14:55:39.14677 from /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:373:in `starttls'
2015-11-06_14:55:39.14677 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/mailbox_watcher.rb:83:in `start_tls'
2015-11-06_14:55:39.14677 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/mailbox_watcher.rb:68:in `setup'
2015-11-06_14:55:39.14678 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/mailbox_watcher.rb:132:in `run'
2015-11-06_14:55:39.14678 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/coordinator.rb:19:in `each'
2015-11-06_14:55:39.14680 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/coordinator.rb:19:in `run'
2015-11-06_14:55:39.14680 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/cli.rb:52:in `start'
2015-11-06_14:55:39.14681 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/bin/mail_room:5:in `<top (required)>'
2015-11-06_14:55:39.14681 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/bin/mail_room:23:in `load'
2015-11-06_14:55:39.14681 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/bin/mail_room:23:in `<main>'
2015-11-06_14:55:39.27303 Runit: starting mail_room
2015-11-06_14:55:49.84488 /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:1158:in `get_tagged_response': TLS is already active. (Net::IMAP::BadResponseError)
2015-11-06_14:55:49.84495 from /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:1210:in `block in send_command'
2015-11-06_14:55:49.84496 from /opt/gitlab/embedded/lib/ruby/2.1.0/monitor.rb:211:in `mon_synchronize'
2015-11-06_14:55:49.84498 from /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:1192:in `send_command'
2015-11-06_14:55:49.84499 from /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:373:in `starttls'
2015-11-06_14:55:49.84500 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/mailbox_watcher.rb:83:in `start_tls'
2015-11-06_14:55:49.84502 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/mailbox_watcher.rb:68:in `setup'
2015-11-06_14:55:49.84503 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/mailbox_watcher.rb:132:in `run'
2015-11-06_14:55:49.84504 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/coordinator.rb:19:in `each'
2015-11-06_14:55:49.84505 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/coordinator.rb:19:in `run'
2015-11-06_14:55:49.84507 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/cli.rb:52:in `start'
2015-11-06_14:55:49.84508 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/bin/mail_room:5:in `<top (required)>'
2015-11-06_14:55:49.84509 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/bin/mail_room:23:in `load'
2015-11-06_14:55:49.84510 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/bin/mail_room:23:in `<main>'
2015-11-06_14:55:49.95165 Runit: starting mail_room
2015-11-06_14:56:00.40494 /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:1158:in `get_tagged_response': TLS is already active. (Net::IMAP::BadResponseError)
2015-11-06_14:56:00.40502 from /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:1210:in `block in send_command'
2015-11-06_14:56:00.40503 from /opt/gitlab/embedded/lib/ruby/2.1.0/monitor.rb:211:in `mon_synchronize'
2015-11-06_14:56:00.40505 from /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:1192:in `send_command'
2015-11-06_14:56:00.40506 from /opt/gitlab/embedded/lib/ruby/2.1.0/net/imap.rb:373:in `starttls'
2015-11-06_14:56:00.40507 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/mailbox_watcher.rb:83:in `start_tls'
2015-11-06_14:56:00.40509 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/mailbox_watcher.rb:68:in `setup'
2015-11-06_14:56:00.40510 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/mailbox_watcher.rb:132:in `run'
2015-11-06_14:56:00.40511 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/coordinator.rb:19:in `each'
2015-11-06_14:56:00.40512 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/coordinator.rb:19:in `run'
2015-11-06_14:56:00.40514 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/lib/mail_room/cli.rb:52:in `start'
2015-11-06_14:56:00.40515 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/gems/mail_room-0.6.1/bin/mail_room:5:in `<top (required)>'
2015-11-06_14:56:00.40517 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/bin/mail_room:23:in `load'
2015-11-06_14:56:00.40519 from /opt/gitlab/embedded/service/gem/ruby/2.1.0/bin/mail_room:23:in `<main>'
2015-11-06_14:56:00.50591 Runit: starting mail_room
This appears to be repeating indefinitely.
Looks like a regression between 8.1.0 and 8.1.3.