500 error on issue viewer when git repository is empty

Trying to open an issue on an empty repository (no code uploaded), I get a 500 error each time I try to view this specific issue. The body of the issue does not make any explicit reference on a commit hash but I think regex parsing assumes there is one and crashes at the end. The problem is verified in my gitlab installation and gitlab.com.

The log produced in my gitlab installation (6.9):

Started GET "/tolabaki/labaki-infrastructure/issues/4" for 91.140.91.50 at 2014-06-17 15:04:48 +0300
Processing by Projects::IssuesController#show as HTML
Parameters: {"project_id"=>"tolabaki/labaki-infrastructure", "id"=>"4"}
Completed 500 Internal Server Error in 77ms
ActionView::Template::Error (undefined method `sha' for nil:NilClass):
48: .description
49: .wiki
50: = preserve do
51: = markdown @issue.description
52: .context
53: %cite.cgray
54: = render partial: 'issue_context', locals: { issue: @issue }
app/helpers/gitlab_markdown_helper.rb:190:in `current_sha'
app/helpers/gitlab_markdown_helper.rb:171:in `file_exists?'
app/helpers/gitlab_markdown_helper.rb:147:in `relative_file_path'
app/helpers/gitlab_markdown_helper.rb:127:in `rebuild_path'
app/helpers/gitlab_markdown_helper.rb:72:in `block in create_relative_links'
app/helpers/gitlab_markdown_helper.rb:70:in `each'
app/helpers/gitlab_markdown_helper.rb:70:in `create_relative_links'
lib/redcarpet/render/gitlab_html.rb:52:in `preprocess'
app/helpers/gitlab_markdown_helper.rb:51:in `render'
app/helpers/gitlab_markdown_helper.rb:51:in `markdown'
app/views/projects/issues/show.html.haml:51:in `block in _app_views_projects_issues_show_html_haml__730927417537140019_55815820'
app/views/projects/issues/show.html.haml:50:in `_app_views_projects_issues_show_html_haml__730927417537140019_55815820'
app/controllers/projects/issues_controller.rb:58:in `show'
app/controllers/application_controller.rb:59:in `set_current_user_for_thread'

The body of the issue that is sufficient to reproduce this bug, even on gitlab.com ( check it here )

Jun 17 13:54:54 idea systemd[1]: sssd.service lacks ExecStart setting. Refusing.

I suppose that code tries to match git hashes found through markdown parsing but fails because there are no commits at all. Unfortunately I am not familiar with ruby to investigate further and provide a patch :( But I would love to see this fixed!

You can find isolated the body of issue in this snippet https://gitlab.com/snippets/1356

It tries to parse the sssd.service path. You should be able to reproduce the issue with any other path too.

This seems resolved in 6.9.2 e46b644. At least I cannot reproduce it on my instance. Are you sure you are running the latest stable version?

I can reproduce it with 6.9.2 Debian 7 omnibus package.

My server was running 6.8.1 but I just upgraded to latest (6.9.2) and I can confirm the bug persists. Notice that you need a project with EMPTY code repository (don't push anything).

Can reproduce it with 6.9.2 e46b644a, too.

This seems resolved in 7.0.0.rc1 fa0e01b, which gitlab.com is now running.

aha! Indeed now the test in gitlab.com is now working (yesterday didn't) ! So it should be closed right?

Yeap! Thanks for reporting.

Status changed to closed

Status changed to reopened

@sque you should add a comment why you reopened this issue. :)

I have reopened this issue as I found a new case with exactly the same behavior (500 error viewing an issue if repository is empty). This problem exists on version 7.0 and can be verified on gitlab.com ( check it here )

The body of the issue that provokes this problem can be found at https://gitlab.com/snippets/1407

The output of production.log produced in my server:

Completed 500 Internal Server Error in 73ms

ActionView::Template::Error (undefined method `sha' for nil:NilClass):
    48:     .description
    49:       .wiki
    50:         = preserve do
    51:           = markdown @issue.description
    52:   .context
    53:     %cite.cgray
    54:       = render partial: 'issue_context', locals: { issue: @issue }
  app/helpers/gitlab_markdown_helper.rb:173:in `current_sha'
  app/helpers/gitlab_markdown_helper.rb:158:in `file_exists?'
  app/helpers/gitlab_markdown_helper.rb:149:in `path_with_ref'
  app/helpers/gitlab_markdown_helper.rb:110:in `rebuild_path'
  app/helpers/gitlab_markdown_helper.rb:66:in `block in create_relative_links'
  app/helpers/gitlab_markdown_helper.rb:65:in `each'
  app/helpers/gitlab_markdown_helper.rb:65:in `create_relative_links'
  lib/redcarpet/render/gitlab_html.rb:48:in `postprocess'
  app/helpers/gitlab_markdown_helper.rb:51:in `render'
  app/helpers/gitlab_markdown_helper.rb:51:in `markdown'
  app/views/projects/issues/show.html.haml:51:in `block in _app_views_projects_issues_show_html_haml__3465014039306313060_51409000'
  app/views/projects/issues/show.html.haml:50:in `_app_views_projects_issues_show_html_haml__3465014039306313060_51409000'
  app/controllers/projects/issues_controller.rb:58:in `show'

sry @cschulz, didn't know which order is best to do it, first reopen and then write a comment or the opposite around? :P (It would be nice actually use that the comment box is used when you press Close or Reopen and not through away the text)

@sque yes that would be a nice enhancement, but for that you need to open a feedback "discussion" on the feedback site (http://feedback.gitlab.com). I was just surprised because I got notified instantly without any further information ;)

I will do it the other way around next time :)

So this is a markdown regression, containing the word Os, when in addition a repo is empty? And this is happening only with ###? What if it is # or ##? Have you investigated? I'm trying to narrow it down.

I didn't try to investigate further, apart from finding exactly which line provoked the problem. I can confirm though, that this is a regression bug in version 7.0 (or maybe 6.9). This was the body of old issue that was working and had no problem until the upgrade.

mentioned in issue #357 (closed)

Fixed by 1e673c72

@sque Can you apply the above patch and confirm it works? Thanks!

Status changed to closed