Pipeline not updated in MR widget when the latest one is skipped

Description

In this merge request pipeline has not been updated in the merge request widget. The latest one has been skipped, so maybe this is the problem. See screenshot blow.

/cc @ayufan

Testing this in https://gitlab.com/grzesiek/ci-cd-sandbox/merge_requests/4.

This bug is still present and I was able to reproduce it on gitlab.com.

See https://gitlab.com/grzesiek/ci-cd-sandbox/merge_requests/4/commits

assigned to @grzesiek

changed milestone to %10.1

added Deliverable In dev labels

@bikebilly @bikebilly I just added a Deliverable label, this will be part of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14482.

mentioned in merge request !14482 (merged)

added In review and removed In dev labels

mentioned in commit 057a8b70

@bikebilly I think that if MWPS is set, then skipped pipeline is clearly not successful, so we should not merge.

This means that when someone clicks "MWPS" a green pipeline is expected, not a skipped one, to merge.

@bikebilly I think it is important to show latest pipeline in the widget, regardless of a status. Currently it should not affect MWPS.

Note that this is In review already.

My comment was to say: should we consider that for MWPS?

We do, @bikebilly. Only a successful pipeline can trigger MWPS, and it has be to be a pipeline associated with the latest commit in the repository.

closed via merge request !14482 (merged)

mentioned in commit 0bba522f

mentioned in merge request !14785