Make edit comment button always available outside of dropdown

Problem

to quote myself from chat https://gitlab.slack.com/archives/C03MSG8B7/p1498740172551524

How do we feel about this feature? I think it’s nice, but went maybe a little to far. I think the edit button, which is the most frequently used should stay available outside of the pop-up, while more severe actions such as delete and reporting of abuse can be in the popup

I think in this direction, because we are not a IM messaging platform such as slack.. so comments have more weight to it.. thus editing of comments happens more often. Also the shortcut with button up.. is a bit of a power user feature.

Requirements for this issue

• Move edit icon out of dropdown. It is shown (outside the dropdown), if the user has permissions to edit the comment.
• The kebab menu also is present. The menu items in the kebab menu are Report as abuse and Delete comment. These items are shown only if the user has permissions.

Original proposal

- Move icon out of dropdown, to always available.

That means that the dropdown sometimes only has one item available Report abuse when Delete comment is not available.

• If dropdown would only have one item.. just use icon.. instead of 1 icon.

Probably needed here: icon for Report abuse cc: @hazelyang

cc: @JobV @dzaporozhets @kushalpandya (as you were part of the conversation at https://gitlab.slack.com/archives/C03MSG8B7/p1498740172551524) cc: @victorwu @smcgivern (can we see this as either an iteration or a regression fix?)

Probably needed here: icon for Report abuse

@dimitrieh Will do!

I’ve just upgrade to 9.3.2 and was shocked, that Edit button for comments was moved into dropdown menu, which has TWO items. WHY? Who thought about moving edit button under menu? Why? This is huge hit to usability: something used to be simple — edit comment, something I do hundred times a day, was requiring one click, now it’s two clicks What is the advantage of this? I see none, only disadvantage. You really should stop playing with usability of the project -— it’s not improvement -— it’s making product worse.

Why move it under menu? Delete + abuse -- can go into menu, they are not that frequently used, but edit should be always one click away!

9.2.x:

9.3.x:

This is regression and should be fixed in 9.3.3!

added customer label

customer was extremely upset about this in ZD: https://gitlab.zendesk.com/agent/tickets/79557

Report abuse icon:

Looks like !11352 (merged) was merge request where this bug was created. I propose reverting it. It broke workflows and it is bad UI.

@dimitrieh Can we tag this a regression? This change has had a major impact on the workflow of our customers.

Thanks

/cc @smcgivern

added Next Patch Release SP1 regression labels

assigned to @psimyn

created branch 34527-make-edit-comment-button-always-available-outside-of-dropdown

mentioned in merge request !12931 (merged)

changed milestone to %9.3

added UX label

@psimyn : Before we merge this in, can we please have a more thorough UX review. Sorry for the last minute comment.

@dimitrieh @tauriedavis : There's a lot of functionality in the comment UI. Please see the designs here: https://gitlab.com/gitlab-org/gitlab-ce/issues/32451.

Can you folks please have a final design that incorporates everything before we merge these changes. (I have no problem with moving the Edit button out by itself. But I want to make sure that UX has intentionally reviewed the entire design.

Thanks @victorwu - I'd much prefer last minute that post-merge

I've added screenshots to the https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12931, ready for UX Review

I wasnt aware of this issue. I have the same question as @victorwu. With resolvable discussions coming, we would have five icons.

Those four plus the edit icon.

@sarrahvesselov since @dimitrieh is on vacation, can you provide some clarity on how we want to move forward? I personally think having five tasks is a lot which is why some were moved into the dropdown.

Can you folks please have a final design that incorporates everything before we merge these changes. (I have no problem with moving the Edit button out by itself. But I want to make sure that UX has intentionally reviewed the entire design.

Yes, I agree that this is necessary @victorwu. I also have no problem moving the Edit button out on it's own, but we should stop there.

It looks like this never got the UX Ready label so I am unsure of how it got to this stage. It shouldn't have.

I personally think having five tasks is a lot which is why some were moved into the dropdown.

I think Edit should not be hidden but in looking at the linked issue, I don't see an opportunity to move any of the other items into the menu. The Edit will only show on comments the user can edit, so I am not sure that there will be much of a cognitive overload.

If dropdown would only have one item.. just use icon.. instead of 1 icon.

I think it gets complicated here, sometimes it will be in a dropdown, sometimes not. I don't think we should do this, it is fine if there is one item in the dropdown.

@psimyn : Per https://gitlab.com/gitlab-org/gitlab-ce/issues/34527#note_35995836, can we please proceed with just doing this design:

I.e. always have the kebab menu, even if the only menu item is Report as abuse. Updating the description here.

changed the description

closed via merge request !12931 (merged)

mentioned in issue #36431

mentioned in commit cf55fb9b

mentioned in commit b05ae3c9