Developer can run manual ci job on protected tags
Summary
Developer can run manual ci job on protected tags, as they can not run manual ci job on protected branches.
Steps to reproduce
use developer role run manual ci job on protected tags
What is the current bug behavior?
Developer can run manual ci job on protected tags
What is the expected correct behavior?
Developer can not run manual ci job on protected tags
Results of GitLab environment info
System information
System: CentOS 7.3.1611
Current User: git
Using RVM: no
Ruby Version: 2.3.3p222
Gem Version: 2.6.6
Bundler Version:1.13.7
Rake Version: 10.5.0
Redis Version: 3.2.5
Git Version: 2.13.0
Sidekiq Version:5.0.0
Go Version: unknown
GitLab information
Version: 9.3.5
Revision: 0c9ceb3
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
URL: https://git.ahlll.net
HTTP Clone URL: https://git.ahlll.net/some-group/some-project.git
SSH Clone URL: git@git.ahlll.net:some-group/some-project.git
Using LDAP: no
Using Omniauth: no
GitLab Shell
Version: 5.1.1
Repository storage paths:
- default: /mnt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks
Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Checking GitLab Shell ...
GitLab Shell version >= 5.1.1 ? ... OK (5.1.1)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:root, or git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
9/3 ... ok
5/15 ... ok
5/16 ... ok
5/17 ... ok
10/19 ... ok
17/21 ... repository is empty
17/22 ... ok
15/24 ... ok
10/25 ... ok
10/26 ... ok
10/28 ... repository is empty
17/30 ... ok
15/31 ... ok
16/32 ... ok
14/33 ... ok
9/35 ... repository is empty
5/37 ... ok
5/42 ... ok
28/45 ... ok
28/46 ... ok
28/48 ... ok
28/53 ... ok
28/54 ... ok
28/56 ... ok
5/57 ... ok
5/58 ... ok
28/60 ... ok
28/61 ... ok
28/62 ... ok
5/63 ... repository is empty
35/64 ... ok
39/65 ... repository is empty
5/66 ... ok
28/67 ... ok
9/75 ... ok
11/79 ... ok
5/80 ... ok
13/81 ... ok
45/82 ... ok
5/84 ... ok
46/85 ... ok
45/86 ... ok
4/88 ... ok
5/89 ... ok
15/90 ... repository is empty
20/91 ... ok
24/92 ... ok
11/96 ... ok
45/97 ... ok
34/98 ... ok
5/99 ... ok
28/100 ... ok
28/101 ... ok
28/102 ... ok
5/104 ... ok
35/105 ... ok
14/106 ... ok
45/107 ... ok
28/110 ... ok
5/111 ... ok
5/112 ... ok
28/113 ... ok
5/114 ... ok
5/115 ... ok
45/118 ... ok
45/119 ... ok
15/120 ... repository is empty
28/121 ... ok
45/123 ... ok
28/126 ... ok
28/127 ... ok
28/128 ... ok
28/129 ... ok
28/130 ... ok
28/131 ... ok
44/132 ... ok
6/134 ... ok
26/136 ... ok
43/137 ... ok
3/138 ... ok
5/139 ... ok
44/140 ... ok
28/141 ... ok
28/143 ... ok
4/144 ... ok
9/146 ... ok
11/147 ... ok
5/148 ... ok
29/149 ... ok
28/150 ... ok
3/151 ... ok
5/152 ... ok
10/154 ... repository is empty
5/157 ... ok
28/158 ... repository is empty
28/159 ... ok
5/160 ... ok
46/161 ... ok
29/162 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
9/3 ... yes
5/15 ... yes
5/16 ... yes
5/17 ... yes
10/19 ... yes
17/21 ... yes
17/22 ... yes
15/24 ... yes
10/25 ... yes
10/26 ... yes
10/28 ... yes
17/30 ... yes
15/31 ... yes
16/32 ... yes
14/33 ... yes
9/35 ... yes
5/37 ... yes
5/42 ... yes
28/45 ... yes
28/46 ... yes
28/48 ... yes
28/53 ... yes
28/54 ... yes
28/56 ... yes
5/57 ... yes
5/58 ... yes
28/60 ... yes
28/61 ... yes
28/62 ... yes
5/63 ... yes
35/64 ... yes
39/65 ... yes
5/66 ... yes
28/67 ... yes
9/75 ... yes
11/79 ... yes
5/80 ... yes
13/81 ... yes
45/82 ... yes
5/84 ... yes
46/85 ... yes
45/86 ... yes
4/88 ... yes
5/89 ... yes
15/90 ... yes
20/91 ... yes
24/92 ... yes
11/96 ... yes
45/97 ... yes
34/98 ... yes
5/99 ... yes
28/100 ... yes
28/101 ... yes
28/102 ... yes
5/104 ... yes
35/105 ... yes
14/106 ... yes
45/107 ... yes
28/110 ... yes
5/111 ... yes
5/112 ... yes
28/113 ... yes
5/114 ... yes
5/115 ... yes
45/118 ... yes
45/119 ... yes
15/120 ... yes
28/121 ... yes
45/123 ... yes
28/126 ... yes
28/127 ... yes
28/128 ... yes
28/129 ... yes
28/130 ... yes
28/131 ... yes
44/132 ... yes
6/134 ... yes
26/136 ... yes
43/137 ... yes
3/138 ... yes
5/139 ... yes
44/140 ... yes
28/141 ... yes
28/143 ... yes
4/144 ... yes
9/146 ... yes
11/147 ... yes
5/148 ... yes
29/149 ... yes
28/150 ... yes
3/151 ... yes
5/152 ... yes
10/154 ... yes
5/157 ... yes
28/158 ... yes
28/159 ... yes
5/160 ... yes
46/161 ... yes
29/162 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.3 ? ... yes (2.3.3)
Git version >= 2.7.3 ? ... yes (2.13.0)
Active users: ... 51
Checking GitLab ... Finished
/label bug
Edited by username-removed-1282755