Provide more feedback when have_http_status failed
This was originally mentioned from https://gitlab.com/gitlab-org/gitlab-ce/issues/33898#note_34616958
@rymai has a great direction that:
Another thing would be to define a custom matcher that would print more than the
have_http_status
matcher from rspec-rails: https://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/matchers/have_http_status.rb#L104-L105
Link with latest tag in case master is off: https://github.com/rspec/rspec-rails/blob/v3.6.0/lib/rspec/rails/matchers/have_http_status.rb#L104-L105
So let's try to have this:
expect(response).to have_http_status(200)
Changed to:
expect(response).to have_gitlab_http_status(200) # inspired by gitlab_sign_in