Validate approvals before merge Approvals disabled for target project

I can't edit my merge request and remove a "WIP: " prefix. It gives an error "Validate approvals before merge Approvals disabled for target project". The error is particularly cryptic & frustrating. This just started. I can't see anywhere in project settings where to even turn that on, nor have I turned it on. This is completely blocking us from working & we're not sure how to solve it. Please fix.

mentioned in issue #35080 (moved)

mentioned in issue #35084 (moved)

I can't manually close the merge request either, it takes me to the edit form w/ the same error on top.

I ran into this as well. The only option that I had was to delete the MR. I merged it during the upgrade, so in Git the changes are already in my master branch. But now I have lost the history of that MR review and that the MR even existed.

mentioned in issue #35077 (closed)

Maybe something related from what I posted here:

Weird behavior in MRs for me too. I got this error (https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/6239):

This ^^ error can be reproduced by editing an MR description. Just happened again

/cc @smcgivern @nick.thomas

added Discussion Next Patch Release regression labels

changed milestone to %9.4

Looks like this might have been introduced by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2324

This likely happens because the MergeRequest#validate_approvals_before_merge validation runs even when the Approvers feature is not available on this GitLab instance or the specific GitLab.com group/project.

We likely need to add a project.feature_available?(:merge_request_approvers) check to it.

/cc @nick.thomas

I'm running into something that seems related:

When I try to submit a merge request I get a 500 error. If I try to do it via the API I get:

gitlab.exceptions.GitlabCreateError: 400: {'validate_approvals_before_merge': ['Approvals disabled for target project'], 'project_access': [], 'branch_conflict': [], 'validate_fork': [], 'validate_branches': [], 'base': []}

We were previously using the approval feature on gitlab.com while using the free plan and haven't upgraded yet. Now we can't submit any merge requests, and I can't disable the approval feature via the UI either.

@petebrowne Definitely related. Can you try again in GitLab.com now? It should be fixed.

assigned to @nick.thomas

Yeah it worked this time! Thanks for the extremely quick response

I have this merge request open: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2426

marked this issue as related to #35077 (closed)

mentioned in issue gitlab-com/infrastructure#2250 (closed)

marked this issue as related to #35111 (closed)

mentioned in merge request !14785