Commit comments don't trigger notifcations unless user is mentioned

• Zendesk ticket: https://gitlab.zendesk.com/agent/tickets/12113
• Dev link: None
• GitLab version: 8.1.4

Expected behavior

If a commit comment is made it should notify the commit author.

Observed behavior

If a commit comment does not mention a user, no notification is sent. If a user is mentioned, notifications are generated, but only to the mentioned user (not the commit author).

Next steps

cc/ @vsizov Should a commit comment trigger notifications to the commit author?

@dblessing Sure, it's a bug.

I'm scheduling for 8.3, hoping it's small. Please adjust if necessary.

Milestone changed to 8.3

Hi, I'm not able to replicate this bug in master in my local environment. It sends an email correctly to the commit author. Also there are specs written for it: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/spec/services/notification_service_spec.rb#L164

Is there a chance the affected user has notifications disabled? or any other detail mentioned by the user in how to reproduce this one?

@jcorcuera I was able to reproduce this locally. Have you tried by adding comments to a single commit?. When commenting on a MR's diff it works fine though.

Reassigned to @dbalexandre

@dbalexandre Please cc me on the MR, I'm pretty familiar with this bunch of logic so I'd like to review any changes :)

@DouweM I'll

I'm not able to replicate this bug in my local environment too. I tried by adding comments to a single commit and, also in the MR's diff. Like @jcorcuera mentioned, it sends an email correctly to the commit's author, except when the user that wrote the comment is the same author of the commit.

@rdavila Could you give the steps you made to reproduce this error locally?

@dbalexandre looks like I've run into a special case: when the committer is not a GitLab user.

The way I've tested is by going to the list of commits, for instance: https://gitlab.com/gitlab-org/gitlab-ce/commits/master

Then try to comment on a commit that is owned by an external user (a User that isn't registered on GitLab) and you should not see the email being sent. We have the email from the committer but I'm not sure if we want to handle this scenario.

@rdavila I replicated the scenario you mentioned locally and, like you said, no email is being sent to external users (a User that isn't registered on GitLab).

@dblessing The user mentioned other details that could help us in how to reproduce this one?

I reproduced this on a fresh GitLab install right before reporting this. I'll test again, though.

@dbalexandre @rdavila You're right. I cannot reproduce this anymore. I think the current behavior is correct. If we all agree, let's close this.

I've reported back to the user and am asking them to verify our findings. I'll close for now and reopen if necessary.

Status changed to closed