lfs issue "relation does not exist"

With export GIT_CURL_VERBOSE=true:

# ~ → git clone git@gitlab.com:gitlab-org/University.git
Cloning into 'University'...
remote: Counting objects: 28, done.
remote: Compressing objects: 100% (26/26), done.
remote: Total 28 (delta 3), reused 0 (delta 0)
Receiving objects: 100% (28/28), done.
Resolving deltas: 100% (3/3), done.
Checking connectivity... done.
Downloading classes/images/emoji.png (37.58 KB)
> POST /gitlab-org/University.git/info/lfs/objects/batch HTTP/1.1
> Host: gitlab.com
> Accept: application/vnd.git-lfs+json; charset=utf-8
> Content-Type: application/vnd.git-lfs+json; charset=utf-8
> User-Agent: git-lfs/1.0.2 (GitHub; darwin amd64; go 1.5.1)
>
{"objects":[{"oid":"e7b60a483d88917ebc5974ddd46686d4fc0ab1a6bf70ad6a9d6fae05d8b237fa","size":38477}],"operation":"download"}< HTTP/1.1 401 Unauthorized
< Transfer-Encoding: chunked
< Cache-Control: no-cache
< Content-Type: text/plain
< Date: Thu, 19 Nov 2015 16:13:57 GMT
< Server: nginx
< Status: 401 Unauthorized
< X-Request-Id: ea46232b-dbaf-44cf-9094-596e70059025
< X-Runtime: 0.018684
<
UnauthorizedUsername for 'https://gitlab.com': razer6
Password for 'https://razer6@gitlab.com':
> POST /gitlab-org/University.git/info/lfs/objects/batch HTTP/1.1
> Host: gitlab.com
> Accept: application/vnd.git-lfs+json; charset=utf-8
> Authorization: Basic ********
> Content-Type: application/vnd.git-lfs+json; charset=utf-8
> User-Agent: git-lfs/1.0.2 (GitHub; darwin amd64; go 1.5.1)
>
{"objects":[{"oid":"e7b60a483d88917ebc5974ddd46686d4fc0ab1a6bf70ad6a9d6fae05d8b237fa","size":38477}],"operation":"download"}< HTTP/1.1 200 OK
< Transfer-Encoding: chunked
< Cache-Control: private
< Content-Type: application/json; charset=utf-8
< Date: Thu, 19 Nov 2015 16:14:06 GMT
< Etag: "50aff3b45ad5ab83e3fce927c2f9388f"
< Server: nginx
< Status: 200 OK
< X-Request-Id: 999ed050-ae5e-4970-b7d7-2c36f65d9703
< X-Runtime: 0.190743
<
{"objects":[{"oid":"e7b60a483d88917ebc5974ddd46686d4fc0ab1a6bf70ad6a9d6fae05d8b237fa","size":38477}]}Error accessing media: classes/images/emoji.png (e7b60a483d88917ebc5974ddd46686d4fc0ab1a6bf70ad6a9d6fae05d8b237fa)

Errors logged to .git/lfs/objects/logs/20151119T171406.426319415.log
Use `git lfs logs last` to view the log.
error: external filter git-lfs smudge %f failed 2
error: external filter git-lfs smudge %f failed
fatal: classes/images/emoji.png: smudge filter lfs failed
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry the checkout with 'git checkout -f HEAD'

https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/lfs/response.rb#L37 - this method excepts that this is always a „upload“ operation. However, when doing git lfs fetch client sends „download“ request. Rails app should in response send links to download each of oids, but since this supports only upload operation it sends links only when an object doesn’t exist.

The POST body to project.git/info/lfs/batch contains an 'operation': 'download' or 'upload'. Right now that field is being ignored, and the gitlab-ce code always assumes 'upload'.

      def build_response(objects)
        selected_objects = select_existing_objects(objects)

        upload_hypermedia(objects, selected_objects)
      end

(in lib/gitlab/lfs/response.rb)

to the issue. Does not work for me either

@ayufan @jacobvosmaer who is working on fixing this - please assign issue to yourself

Added promised label

I add label promised to this issue since we must have it fixed before release. I did not find better label

Reassigned to @marin

I assigned it to myself so I can take a look, for me everything works as expected downloading wise and I also tried it on a friends machine where it also works.

This was my version where all worked:

git-lfs/1.0.0 (GitHub; darwin amd64; go 1.5.1)
git version 2.6.1

Endpoint=https://gitlab.com/yorickpeterse/cat-pictures.git/info/lfs (auth=none)
  SSH=git@gitlab.com:yorickpeterse/cat-pictures.git
LocalWorkingDir=/tmp/cat-pictures
LocalGitDir=/tmp/cat-pictures/.git
LocalGitStorageDir=/tmp/cat-pictures/.git
LocalMediaDir=/tmp/cat-pictures/.git/lfs/objects
TempDir=/tmp/cat-pictures/.git/lfs/tmp
ConcurrentTransfers=3
BatchTransfer=true
git config filter.lfs.smudge = "git-lfs smudge %f"
git config filter.lfs.clean = "git-lfs clean %f"

In call with @ayufan we saw that somehow this version still used the older API when it comes to downloading where it only sent the GET requests and it successfully fetched

I am going to upgrade my local version to try to break stuff.

Fix in !1842 (merged)

!1853 (merged) for stable

For future reference: it now seems we ended up implementing LFS downloads in a way that worked with 1.0.0 LFS clients but stopped working with 1.0.1.

@marin do we know if the new code will work with 1.0.0 clients?

@jacobvosmaer Looking at the code of LFS client I don't think it will. Will check and answer.

git-lfs client 1.0.0 is incompatible now.

@jacobvosmaer The error message that client is unsupported will be logged. The user can access the log with git lfs log last.

MRs have been merged and fix will be in 8.2.0.rc2.

Docs update MR is in !1855 (merged)

Status changed to closed

mentioned in merge request !14785

lfs issue "relation does not exist"

Designs

Child items ...

Activity

Admin message

Admin message

lfs issue "relation does not exist"

Activity