I can't remove source branch on MR page

example - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1850

it says - Failed to remove source branch 'notes_fix_to_stable'

I saw this on my production server. It first says Failed to remove source branch 'xyz' and after a reload it says that it deleted it.

@razer6 The same here

Looks like this is a timing issue. Here is the info to reproduce this bug:

Steps

1. Open a new MR
2. On the MR page, check the Remove source branch checkbox and accept the merge request.

Expected

After being redirected to the MR detail page I should not see the Remove source branch button.

Actual

The Remove source branch button is shown and after clicking on it the app raise a 404 error given that the branch no longer exists.

@vsizov can you please confirm these are the right steps to reproduce the error? In the meantime I'm going to tackle this one.

Reassigned to @rdavila

Yes, these are actual steps.

mentioned in merge request !1897 (merged)

mentioned in commit aa1ba009

Status changed to closed by merge request !1897 (merged)

mentioned in commit e7e22ece