Counting contributions to forked projects
Currently commits to forked repositories are not being counted among contributions on profile page.
Is this expected behavior ?
I think that contributions to forked repositories should be also counted and displayed in contributions calendar. Then, when someone creates a merge request, and it gets eventually merged, those contributions can be counted again - in my opinion it is ok, as it gives bigger picture of contributor's work.
Do we have docs page that explains how contributions are counted ?
cc @JobV, @dzaporozhets
Activity
I don't know if we have docs (that means no). I think performance is the main reason to not expand it.
I'm fine with scheduling this for a fix + documentation on it, but it should be fast!
Edited by 🚄 Job van der Voort 🚀
Currently commits to forked repositories are not being counted among contributions on profile page. Is this expected behavior ?
Yes its expected behaviour. There is no problem in counting fork projects on calendar. The reason for this: I think about contribution as something you did to project that is not only for you. Example:
- personal projects
- contributions to other projects
Forked projects are a bit aside so as a visitor I would not be interested that much in seeing user activity there.
If you still think we should include forked projects - lets discuss
Do we have docs page that explains how contributions are counted ?
No. Contribution is one event generated by user. Push code - 1 event. Create issue - 1 event. User A visit page of User B. User A sees all contributions (except forks) of User B to projects that both User A and User B has access to.
@dzaporozhets I understand. However it may be confusing, because user activity feed shows contributions that are not displayed in calendar. This is just a matter of consistency.
-
I understand. However it may be confusing, because user activity feed shows contributions that are not displayed in calendar. This is just a matter of consistency.
@grzesiek valid argument. I am ok with counting forks too
Reassigned to @jameslopez
mentioned in merge request !2918 (merged)
Milestone changed to 8.6
Status changed to closed by commit dc6099a5
mentioned in commit jt-gitlab/gitlab-ce@dc6099a5
Mentioned in commit pfjason/gitlab-ce@dc6099a5
mentioned in merge request !14671 (merged)
