Approval and WIP MR visualization could be confusing
With 9.5 we have new visualization for MR widget, specifically for Approval and when MR is WIP:
When I first saw this I found it surprising. The red X icon was previously used only to show that a pipeline failed. Now that it is used in multiple places, I keep getting confused and keep going to check why the pipeline failed.
I don't know what a better solution would be, but I want to raise this concern as we might want to think about a better icon for these actions.
Design/Solution
The icon indicating approvals required or merge cannot happen, need to be changed to the warning
icon. However the coloring will be set to #2E2E2E
.
Follow up on design for adding more hierarchy to mr-widget is https://gitlab.com/gitlab-org/gitlab-ce/issues/37479