Skip to content
Snippets Groups Projects
New issue look: Off

Merge request email patches and plain diff dropdown

    • Open Issue created by Victor Wu @victorwu

    In the merge request widget, replace

    this

    Screen_Shot_2017-08-15_at_18.03.46

    with

    Screen_Shot_2017-08-15_at_17.48.27

    Pending final colors

    Designs

      Child items ...

      2. Activity

      • Victor Wu changed milestone to %10.1

        changed milestone to %10.1

      • Victor Wu added Discussion UX ~13921 labels

        added Discussion UX ~13921 labels

      • Victor Wu
        Victor Wu @victorwu ·
        Author Reporter

        @smcgivern @dimitrieh : We should update this for consistency right?

      • Victor Wu
        Victor Wu @victorwu ·
        Author Reporter

        @winh : Since you've been doing a lot of the dropdown style updates. Any thoughts on if we should make this design change?

      • Winnie Hellmann
        Winnie Hellmann @winh ·
        Developer

        @victorwu I'm really not a fan of the two-click buttons—especially because they don't keep their state upon page reload. I still wanted to open an issue about that (and inconsistencies with other places in GitLab) but didn't have the time to do so. I hope to get the chance tomorrow and will ping you there.

        /cc @cperessini ... because dropdowns. :wink:

      • Chris Peressini
        Chris Peressini @cperessini ·
        Developer

        I think we should consider how often users need to download plain diffs vs. email patches. I'm not aware of how these features are used, but here are the options I see:

        • If their use is split 50/50, the current dropdown model works best because users will want to select a different option every other time.
        • If it's 80/20, a split button would be a good fit because we can show a default option that most users will need most of the time
        • If it depends on each user's usual workflow, then a split button that remembers the last selected option like @winh mentioned would be what we need here
      • Victor Wu
        Victor Wu @victorwu ·
        Author Reporter

        I'm more concerned about the dropdown style specifically. This is a place in the UI where there is a weird looking dropdown that doesn't match all others.

        In terms of the functionality of dropdowns, I don't see why two-click buttons are good at all. My understanding is that that's what we have currently in GitLab. So this issue is more about bringing consistency and retiring old code/UI.

      • Winnie Hellmann
        Winnie Hellmann @winh ·
        Developer

        I don't see why two-click buttons are good at all

        My understanding is that that's what we have currently in GitLab.

        @victorwu To the best of my knowledge, we have them at two places (which makes them roughly 1% of all dropdowns). :wink: I have created an issue to reconsider them: https://gitlab.com/gitlab-org/gitlab-ce/issues/36623

        There are also other places that use icon-only dropdowns, for example project page and repository: https://gitlab.com/gitlab-org/gitlab-ce

      • Victor Wu changed milestone to %Next 2-3 months

        changed milestone to %Next 2-3 months

      Please register or sign in to reply