Regression: No longer possible to configure JIRA integration without username and password
Summary
We make use of the JIRA integration, but don't want GitLab update anything in JIRA (We use the 'Git integration for JIRA' plugin). But all the links to issues should work, so essentially read-only. This was always easily possible for us by activating the integration but not filling in a username or password.
There seems to be a regression, at least in 9.4 and 9.5, where this is no longer possible. We're now stuck with existing projects which have the integration enabled where we can't update it, and new ones where we can't activate it.
The last version with which we're certain this still worked correctly is 9.0.
Steps to reproduce
Go to settings -> integrations -> JIRA Tick 'Activate' and configure the Web URL Do not fill in a username or password Press 'Test settings and save changes'
What is the current bug behavior?
Saving not possible because username and password are required fields
What is the expected correct behavior?
Saving and activating the integration succeeds when username and password are left empty
Possible fixes
Only check the fields if it has a non-empty value.
Activity
It seems this commit caused the regression in 9.3: https://gitlab.com/gitlab-org/gitlab-ce/commit/33d82ccb453ef020d28f1307be1a3a97130c9e0b
/cc: @jarka
I actually think this is the expected behaviour as described in https://gitlab.com/gitlab-org/gitlab-ce/issues/31511 (the exact part: The save button is inactive (faded green) until you fill out all the fields (all fields are required).
@victorwu could you please take a look?
@boudekerk : Like @jarka mentioned, the design of the integration is that it connects (logs into a JIRA instance via the our integration itself). We fixed this as mentioned above. That is, it is designed so that you have access to the JIRA instance, per our docs: https://docs.gitlab.com/ce/user/project/integrations/jira.html.
As shown in the docs, if you uncheck the checkboxes (commit / merge request), then GitLab will not write to the JIRA issue.
@victorwu @jarka It seems strange to me that the design calls for a user (with must have write access according to the docs), even when configured to not write?
Essentially it's telling me to create a user with write access, who's credentials I then need to share with all masters in my organisation, for no other reason than that the fields exist, not because there's an actual use for that user.....
If that's by design, I'd argue the design is buggy ;-)
I'd say that the pre 9.3 behaviour made much more sense than the current one. So all in all I still feel this is a regression, as it used to work perfectly, only if you needed a user did you have to configure one.
I guess the nicest solution would be to only require the user and password when either of those checkboxes is checked?
I'd kindly ask you to have another look at this, and consider reverting the change until something better can be implemented.
Kind regards, Bartosz
@boudekerk : Thanks for the feedback. Please open a feature request and describe your use case. I think you mean you would like to link to JIRA issues from within GitLab, essentially by just typing PROJ-123? If you could create that issue, we can chat there. Thanks!
mentioned in issue #37193
@victorwu Thank you. I've just created https://gitlab.com/gitlab-org/gitlab-ce/issues/37193
