Replace 'js: true' with ':js' in feature specs
Description
We have some inconsistency in our feature specs with starting the Capybara driver by the js
argument.
There are two variants of passing the js
argument:
js: true
:js
% grep -r 'js: true' spec/features | wc -l
283
% grep -r ':js ' spec/features | wc -l
126
The :js
variant is shorter and a little bit easier to read.
Proposal
- Replace all the
js: true
arguments with the:js
ones. - Add a rubocop cop to prevent using
js: true
.
@rymai @rspeicher @godfat what do you think about adding a cop for catching that?
I like cops.