Make it easier to change notification settings if you're in the group of a project

There is a bug:

1. You're looking at a project homepage of which you're part of the group.
2. You want to change the notification settings but you see you need to be a member
3. You add yourself as a member
4. You reload the project homepage but you still can't change the project notification settings

Maybe the bug is caused by cached credentials in redis.

Solutions:

1. Fix the bug
2. Allow people to change notifications if they are not a member

/cc @JobV @dzaporozhets

Hm annoying. You should be able to change notifications if you're not a member. This is confusing otherwise (and not something you're able to do dep. on your level).

@dzaporozhets I know that a change it scheduled for how we deal with notifications, should we treat this separately?

@sytses I tried to to reproduce it by your steps and I noticed that "add yourself as a project member" does not work for me if I am already a member of group. Maybe that was the case for you. Its not notification button but adding as a member is broken

Milestone changed to 8.3

Probably fix for this is !1942 (merged)

mentioned in issue #3653 (closed)

@dzaporozhets can you confirm that the referenced MR fixed it?

Milestone changed to 8.4

ping @dzaporozhets

Added ~122770 label

can you confirm that the referenced MR fixed it?

@JobV yes.

Maybe 'Signed in Admin can add/remove himself to a group/project' solves 1, but not 2: Allow people to change notifications if they are not a member.

Added ~123454 label

If the user is a group owner/master he can add himself as a project member and change the notification level. To allow people to change notification if they are not a member, I think we have the following approaches:

1. Instead of changing the project member notification level on the project homepage, we can change the group member notification level. Cons: If a group have 3 projects and the user change the notification level in one project, this will be reflected in the other 2 projects;
2. Decouple the notification level from project membership;

@dzaporozhets like mentioned by @job that we have a change scheduled for how we deal with notifications, what you suggest?

Reassigned to @dbalexandre

@sytses @dbalexandre for solving notification issue we have https://gitlab.com/gitlab-org/gitlab-ce/issues/3359 planned

Status changed to closed

Closing this one in favor of #3359 (closed)