Issues sidebar is inconsistent with new navigation sidebar
With the new navigation in place, there are some inconsistencies between it and the issues sidebar. The background color and widths are different between the issues sidebar and the contextual navigation sidebar.
Brought up here: https://gitlab.com/gitlab-org/gitlab-ce/issues/34917#note_39084321 Discussed briefly here in slack: https://gitlab.slack.com/archives/C3ZKL0W4R/p1504283308000593
Activity
mentioned in issue #34917 (closed)
marked this issue as related to #34917 (closed)
I wonder whether we need the background color on the issues sidebar at all. It is part of the issues page but has the feeling of being separate because of this color. Perhaps removing the color altogether would help get rid of the sensation that the issues page is framed and boxed in.
added Discussion label
changed milestone to %Next 2-3 months
Thanks @sarrahvesselov for this issue.
@tauriedavis created #37660 a few days ago to discuss making the sidebar colors the same.
We also had #35740 (closed), in which we discussed removing the background altogether from the issuable sidebar, but we didn't reach a conclusion.
I don't think we have an issue about the sidebar widths, but we had this short discussion in Slack:
Taurie: Why do they have different background colors and widths? Is that intentional?
Chris: The nav sidebar has the width it does because we need to keep its padding consistent with the expanded sidebar. I looked into changing the width of the issuable sidebar and I think it's possible if we tweak the way we show the selected values. In my opinion, the issuable sidebar should be either the same width or thinner than the nav sidebar, since it's lower in the hierarchy.
Pedro: I agree with @cperessini's thoughts regarding the width
Since we already have issues about the sidebar colors, maybe we can repurpose this one to take care of the issuable sidebar's width.
Thanks for the links @cperessini. I looked everywhere for them with no luck. I linked to the slack convo in the description for this issue.
Since we already have issues about the sidebar colors, maybe we can repurpose this one to take care of the issuable sidebar's width.
Not sure if it is needed. In general, the width and color issues are more related to how it fits into the issue page itself. It should not be about making it the same as the navigation, the two are not the same. If the color is changed to white for the issue sidebar, the width ceases to be an issue IMO. I will close this issue and add my comments to #35740 (closed).
