Follow-up from "Hashed storage migration path" - inline the GitLab Shell mv_repository call
The following discussion from !14067 (merged) should be addressed:
-
@nick.thomas started a discussion: While optimising repository creation for %10.0 - https://gitlab.com/gitlab-org/gitlab-ce/issues/34533 - we discovered that shelling out to gitlab-shell comes with at least 100ms of overhead.
If we're going to be doing this 2.5 million times on GitLab.com, that adds up to ~70 hours.
In a new MR, we want might to consider optimising
mv_repository
in the same way we optimizedcreate
- by moving it in-process: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13529