Transient failure of `health_controller_spec` on master (undefined method `[]' for nil:NilClass)
1) HealthController#readiness accessed from whitelisted ip behaves like endpoint responding with readiness data responds with readiness checks data
Failure/Error: @storage_path = config['path']
NoMethodError:
undefined method `[]' for nil:NilClass
Shared Example Group: "endpoint responding with readiness data" called from ./spec/controllers/health_controller_spec.rb:40
# ./lib/gitlab/git/storage/circuit_breaker.rb:43:in `initialize'
# ./lib/gitlab/health_checks/fs_shards_check.rb:128:in `new'
# ./lib/gitlab/health_checks/fs_shards_check.rb:128:in `storage_circuitbreaker_test'
# ./lib/gitlab/health_checks/fs_shards_check.rb:13:in `block in readiness'
# ./lib/gitlab/health_checks/fs_shards_check.rb:11:in `map'
# ./lib/gitlab/health_checks/fs_shards_check.rb:11:in `readiness'
# ./app/controllers/health_controller.rb:15:in `block in readiness'
# ./app/controllers/health_controller.rb:15:in `map'
# ./app/controllers/health_controller.rb:15:in `readiness'
# ./spec/controllers/health_controller_spec.rb:21:in `block (4 levels) in <top (required)>'
# ./spec/controllers/health_controller_spec.rb:24:in `block (4 levels) in <top (required)>'
2) HealthController#readiness accessed from not whitelisted ip accessed with valid token token passed in request header behaves like endpoint responding with readiness data responds with readiness checks data
Failure/Error: @storage_path = config['path']
NoMethodError:
undefined method `[]' for nil:NilClass
Shared Example Group: "endpoint responding with readiness data" called from ./spec/controllers/health_controller_spec.rb:60
# ./lib/gitlab/git/storage/circuit_breaker.rb:43:in `initialize'
# ./lib/gitlab/health_checks/fs_shards_check.rb:128:in `new'
# ./lib/gitlab/health_checks/fs_shards_check.rb:128:in `storage_circuitbreaker_test'
# ./lib/gitlab/health_checks/fs_shards_check.rb:13:in `block in readiness'
# ./lib/gitlab/health_checks/fs_shards_check.rb:11:in `map'
# ./lib/gitlab/health_checks/fs_shards_check.rb:11:in `readiness'
# ./app/controllers/health_controller.rb:15:in `block in readiness'
# ./app/controllers/health_controller.rb:15:in `map'
# ./app/controllers/health_controller.rb:15:in `readiness'
# ./spec/controllers/health_controller_spec.rb:21:in `block (4 levels) in <top (required)>'
# ./spec/controllers/health_controller_spec.rb:24:in `block (4 levels) in <top (required)>'
3) HealthController#readiness accessed from not whitelisted ip token passed as URL param behaves like endpoint responding with readiness data responds with readiness checks data
Failure/Error: @storage_path = config['path']
NoMethodError:
undefined method `[]' for nil:NilClass
Shared Example Group: "endpoint responding with readiness data" called from ./spec/controllers/health_controller_spec.rb:65
# ./lib/gitlab/git/storage/circuit_breaker.rb:43:in `initialize'
# ./lib/gitlab/health_checks/fs_shards_check.rb:128:in `new'
# ./lib/gitlab/health_checks/fs_shards_check.rb:128:in `storage_circuitbreaker_test'
# ./lib/gitlab/health_checks/fs_shards_check.rb:13:in `block in readiness'
# ./lib/gitlab/health_checks/fs_shards_check.rb:11:in `map'
# ./lib/gitlab/health_checks/fs_shards_check.rb:11:in `readiness'
# ./app/controllers/health_controller.rb:15:in `block in readiness'
# ./app/controllers/health_controller.rb:15:in `map'
# ./app/controllers/health_controller.rb:15:in `readiness'
# ./spec/controllers/health_controller_spec.rb:21:in `block (4 levels) in <top (required)>'
# ./spec/controllers/health_controller_spec.rb:24:in `block (4 levels) in <top (required)>'
(https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/33330429)
This failed after merging https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13914.
Edited by Winnie Hellmann