Follow-up from "Add support for i18n on Project Wiki page"
The following discussion from gitlab-ee!2933 should be addressed:
-
@DouweM started a discussion: (+3 comments) This also needs a namespace or a variable. Depending on what follows
the
, this will be translated differently in many languages that have gendered nouns.I realize this wasn't introduced in this MR, which means that the MR the string didn't have
locale/gitlab.pot
run.@reprazent What do you think about requiring all MRs that externalize strings to be reviewed by you or another i18n "expert" for the time being, to catch this kind of stuff? Or do we simply need to educate all of our reviewers better? In any case, we need tricky things like this documented, if they aren't already.
- docs_link = link_to _('Auto DevOps documentation'), help_page_path('topics/autodevops/index.md'), target: '_blank', rel: 'noopener noreferrer'
= (s_('AutoDevOps|Learn more in the %{documentation}') % { documentation: docs_link }).html_safe