Skip to content

Generalise pop-overs to work on hover and implement in existing places

Problem

Currently we have 2 different kinds of pop-overs in our application:

  • On hover - implemented with the blue dot functionality
  • On click - implemented with the gpg signed commits feature

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14582 rebuilt the pop-over feature for the auto devops badge in the pipeline list view. Initially it worked on hover, but had a different functionality from the blue dot implementation, in that it disappeared suddenly and without consent (see https://gitlab.com/gitlab-org/gitlab-ce/issues/38582). This is an inconsistent and unwanted experience vs the blue dot.

The problem with on click pop-overs is that it doesn't replace the discoverability of tooltip information... while if it worked similarly to the blue dot with on hover.. it will. This kind of functionality is wanted for features such as auto devops and I can't find a good reason to not have the same functionality for the gpg signed commits.

Proposal

  • Make the code for pop-overs on hover from the blue dot reusable
  • Generalise implementation across functions already in gitlab (blue dot/gpg signed commits/auto devops badge)

This will/should impact https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14552

Edited by Dimitrie Hoekstra