Large diffs take too long to load
- Zendesk ticket: https://gitlab.zendesk.com/agent/tickets/13281
- Dev link: None
- GitLab version: 8.2
Expected behavior
If an abnormally large number of changes are present in a merge request, the page should still load in a reasonable amount of time and display a message telling the user about the large diff.
Observed behavior
A large merge request may take over a minute to load the page, and then the user sees the large diff with a message about the diff being too large. The page should load faster than > 1 min just to display this message. This was customer reported, but I recently encountered the same issue the first time I visited this merge request - https://dev.gitlab.org/gitlab/GitHost/merge_requests/14
Next steps
Can we improve the way merge requests load when change sets are large?
cc/ @dzaporozhets @DouweM
Activity
Another customer reported issues in https://gitlab.zendesk.com/agent/tickets/15269. It's actually taking longer than 3 minutes to load the merge request so workhorse times out. The default timeout is 1 minute.
This has been an issue for a long time. I think we need to put some priority on it and really improve the handling of large commits in merge requests.
@dblessing I think @jacobvosmaer is working in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2705 actively on it.
Edited by username-removed-2900Thanks @razer6! Looks awesome.
Related to !2705 (merged)
@dblessing I agree on giving it extra attention. I will put 8.6 as deadline
Milestone changed to 8.6
mentioned in merge request gitlab_git!72 (merged)
mentioned in merge request !3185 (merged)
Status changed to closed by commit 726f1efd
mentioned in commit 726f1efd
mentioned in commit f14ee2f2
Mentioned in commit pfjason/gitlab-ce@f14ee2f2
Mentioned in commit pfjason/gitlab-ce@726f1efd
mentioned in commit test-nick/gitlab-ce@3bd25b79
