False negatives in spinach tests
Next false negatives I've found are located in spinach tests:
Same commit (b88e20d5):
https://gitlab.com/gitlab-org/gitlab-ce/builds/432015 (failed)
https://gitlab.com/gitlab-org/gitlab-ce/builds/432069 (passed)
gitlab_ci_service.rb:58:in `get_ci_commit': undefined method `id' for nil:NilClass (NoMethodError)
Details:
/home/gitlab-runner/builds/a0cbf23b/0/gitlab-org/gitlab-ce/app/models/project_services/gitlab_ci_service.rb:58:in `get_ci_commit': undefined method `id' for nil:NilClass (NoMethodError)
from /home/gitlab-runner/builds/a0cbf23b/0/gitlab-org/gitlab-ce/app/models/project_services/gitlab_ci_service.rb:62:in `commit_status'
from /home/gitlab-runner/builds/a0cbf23b/0/gitlab-org/gitlab-ce/app/controllers/projects/merge_requests_controller.rb:187:in `ci_status'
from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/actionpack-4.2.4/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
from /home/gitlab-runner/lib/ruby/gems/2.1.0/gems/actionpack-4.2.4/lib/abstract_controller/base.rb:198:in `process_action'
...