Regression: Home page url setting to redirect non logged in users doesn't work

Dev: https://dev.gitlab.org/gitlab/gitlabhq/issues/2476

Patricio

Description of issue

The Home page url setting to redirect non logged in users to a different URL no longer works with 7.12. I can confirm that it was working on 7.11.4

Result of replication

I used 7.12.2 to replicate this and it doesn't redirect to the specified URL, it goes to /users/sign_in.

Concrete questions / Next steps

@job this is clearly a bug, and a regression, since it was working on 7.11. Can you schedule it?

Jacob

linked as a 7.12 regression in https://gitlab.com/gitlab-org/gitlab-ce/issues/1810#note_1590938

Robert

jacobvosmaer patricio This was fixed in CE by gitlab-org/gitlab-ce!928

I confirmed it's broken in EE, but applied the change manually and it works as expected. So this issue will be fixed by ce-to-ee merge.

Jacob

so this is fixed on master but not in 7-12-stable?

Robert

I believe so.

Patricio

I see the fix for this in on 7.13. Are we planning on releasing for 7.12 as well, or not anymore?

Valery

dzaporozhets What do you think? How important is it? I'm busy with approvals, I need to ship it with 7.13. So I'd prefer to do patch release if it's really worth it.

Dmitriy

rspeicher can you fix this one?

Jacob

dzaporozhets it is fixed in master, the fix is going into 7.13. The question is whether this fix should be back-ported into 7-12-stable. (Right @valery ?)

Dmitriy

jacobvosmaer I think 7.13 is enough

Sytse

job What is the status of this?

Job

fixed in 7.13. Not back ported to 7.12. I'm in the middle about back porting it. It's an annoying bug and 7.13 upgrade requires downtime. @patricio can you ask the customer whether upgrading to 7.13 is acceptable?

Sytse

job OK, I missed comment about this being fixed.

Patricio

job I asked the customer if upgrading is acceptable. I'll report back when he answers.

Patricio

job he is OK with upgrading to 7.13. Since this has been fixed, the customer is aware of the fix and it is already on the RC for 7.13, I will close this ticket.

Sytse

Does the fix for this maybe cause ERR_TOO_MANY_REDIRECTS when logging out? https://about.gitlab.com/2015/07/22/gitlab-7-13-released/#comment-2151061212

Robert

sytse It looks like the root cause of the linked issue was the user setting their home_page_url setting to the root URL of their installation, resulting in a redirect loop for signed-out users. We could either check if this condition is present before doing the redirect, or prevent the user from entering their root URL as their home page URL in the admin settings preemptively.

Sytse

rspeicher Thanks! I'm fine with either solution for https://gitlab.com/gitlab-org/gitlab-ce/issues/2057

Job

The issue mentioned above is separate from the initial regression, but should be fixed none the less. Therefore 7.14.

Unclear issue, not further linked complaints. There is a suggested fix here, but not high priority: https://gitlab.com/gitlab-org/gitlab-ce/issues/2057#note_1669362 Moving up.

cc/ @dzaporozhets @sytses @jacobvosmaer @vsizov @JobV @patricio @rspeicher

I think this is solved by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/928/diffs

Status changed to closed