mergeInProgress JS can redirect user to an invalid URL
Something to keep an eye out for, not 100% sure on reproduction yet:
- I went to a MR from an email notification, it pointed to a note: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2153#note_2990776
- I checked "Remove source branch"
- Hit the drop-down and then "Merge Immediately"
- The browser URL changed to
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/note_2990776?delete_source=true
(note lack of MR ID and hash for the note anchor) - The "Merge in progress" message never disappeared, likely due to the now-invalid URL.