Infinite scroll (re)loads the same information

Loading commits page, eg. for gitlab.yml.example commits, will show the same information over and over again.

Scroll down to see that commit after 02 May, 2015 is 14 Dec, 2015 and this repeats again if you scroll down.

cc @brodock @dbalexandre @DouweM @rspeicher @JobV

mentioned in issue #4127 (closed)

@marin this must be duplicate of https://gitlab.com/gitlab-org/gitlab-ce/issues/4181, https://gitlab.com/gitlab-org/gitlab-ce/issues/3574 and https://gitlab.com/gitlab-org/gitlab-ce/issues/2410

It was first reported like 4 months ago but still no fix.

/cc @jschatz1

Reassigned to @jschatz1

Added frontend label

#3574 (closed) makes me think this is a backend issue, not a frontend one.

@rspeicher It is. I am unassigning. The network tab queries for

• https://gitlab.com/gitlab-org/gitlab-ce/commits/master/config/gitlab.yml.example?ref=master&limit=40&offset=120
• https://gitlab.com/gitlab-org/gitlab-ce/commits/master/config/gitlab.yml.example?ref=master&limit=40&offset=160

That says to me that it isn't returning the right data.

Assignee removed

Removed frontend label

Added ~127617 label

gitlab_git calls git log, and the problem appears that git log doesn't seem to obey the --skip argument when:

1. --follow is used
2. A specific file is given

For example:

$ git log -n 5 --follow -n 2 --skip=0 -- config/gitlab.yml.example
commit 3d369a5b85ecebdb884b43764b0b21ee2bfad0ad
Author: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Date:   Tue Feb 10 09:30:39 2015 -0800

    Remove settings from gitlab.yml.example which we already have in UI

commit 49d6721329bd9fccf656bb750ee8f6c712852cf6
Author: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Date:   Sat Feb 7 13:49:05 2015 -0800

    Add gitlab to oauth providers

Now with using a non-zero offset:

$ git log -n 5 --follow -n 2 --skip=2 -- config/gitlab.yml.example
commit 3d369a5b85ecebdb884b43764b0b21ee2bfad0ad
Author: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Date:   Tue Feb 10 09:30:39 2015 -0800

    Remove settings from gitlab.yml.example which we already have in UI

commit 49d6721329bd9fccf656bb750ee8f6c712852cf6
Author: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Date:   Sat Feb 7 13:49:05 2015 -0800

    Add gitlab to oauth providers

Same result. Now if I omit --follow:

$ git log -n 5 -n 2 --skip=2 -- config/gitlab.yml.example
commit 087c4cbc3cba2cce1c25773af304833d217976fc
Author: Jacob Vosmaer <contact@jacobvosmaer.nl>
Date:   Wed Jan 28 11:08:44 2015 +0100

    Make 'plain', port 389 the default for LDAP

commit d005c44816b87637b5952dd50178fb7e94e30cc2
Author: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Date:   Thu Jan 22 10:38:24 2015 -0800

    Mix wrong comment about signup

I wonder if this is a bug in git, or whether it is intentional since to follow a deleted file you may not be able to skip offsets.

Thanks for looking at it again. :(

mentioned in merge request !2210 (merged)

Status changed to closed by merge request !2210 (merged)

mentioned in commit ff8cd116

mentioned in commit 08b4d8b6

mentioned in commit 795a29ae