Upvote all the things!
Dev: https://dev.gitlab.org/gitlab/gitlabhq/issues/1474
-
upvote without comments http://feedback.gitlab.com/forums/176466-general/suggestions/5379851-vote-issues-merge-requests-without-comment
-
upvote comments http://feedback.gitlab.com/forums/176466-general/suggestions/3784679-upvote-1-and-downvote-1-for-comments
What do you guys think? I don't like the idea of downvoting comments (unnecessary negativity), but it would be consistent with MRs.
Sytse
This would need data for comments or something like that. We could also include data for time targets and time spend: http://feedback.gitlab.com/forums/176466-general/suggestions/4161532-add-time-tracking-for-issues-similar-to-feng-offic Maybe add four indexed columns (upvote, downvote, time_target, time_spend) to the comments table?
And disable showing and notifications if people upvote with a button instead of creating a comment manually? This can be done with a 'hidden' or 'automatic' column in the comments table.
Job
Good ideas. The addition of time targets is cool, but why on comments?
Sytse
I think that comments are a great interface for them, it allows you to add many items with many people in a historic way.
Job
👍
Dmitriy
1) upvote without comments
Good idea. Still I like to know who upvote stuff. So I would like to see some kind of system comment like sytse upvoted this issue anyway.
** 2) up vote comments **
Looks like redundant functionality to me. GitLab is not reddit and HN. Off topic: I think we should remove downvote functionally from GitLab (issues, mr). I rarely saw downvote on dev.gitlab.org and I think most of time you are looking for some kind of approval in form of up vote. If people don't like your idea they don't up vote. If they change their opinion - they upvote later
if you agree with me about donwvoting I can create a separate issue. I will be glad to throw away this code and simplify UI. This ugly progress bar with upvotes/downvotes annoy me
Jacob
Downvotes are in the API for MRs thanks to Jolla.
Dmitriy
we can keep it in API returning always
0
Sytse
I think we agree:
- Add 'hiding' upvotes (no email, not visible by default)
- Remove downvotes
- Cleaner UI (it would be awesome if we can add time target and time spend later in the same style)
Dmitriy
I created this issue to improve voting https://dev.gitlab.org/gitlab/gitlabhq/issues/1491