Update rails to 4.2.5

debian already has 4.2.5 and I get the following error when installing.

== Seed from /usr/share/gitlab/db/fixtures/production/001_admin.rb
rake aborted!
ActiveModel::MissingAttributeError: can't write unknown attribute `runners_registration_token`
/usr/share/gitlab/app/models/concerns/token_authenticatable.rb:22:in `block in add_authentication_token_field'
/usr/share/gitlab/app/models/application_setting.rb:98:in `create_from_defaults'
/usr/share/gitlab/lib/gitlab/current_settings.rb:8:in `current_application_settings'
/usr/share/gitlab/app/models/user.rb:578:in `set_projects_limit'
(eval):9:in `block (2 levels) in run_file'
/usr/share/gitlab/lib/tasks/gitlab/setup.rake:20:in `setup_db'
/usr/share/gitlab/lib/tasks/gitlab/setup.rake:4:in `block (2 levels) in <top (required)>'
Tasks: TOP => db:seed_fu
(See full trace by running task with --trace)

mentioned in issue debian-ruby/TaskTracker#49 (closed)

Added gem update label

It is working in gitlab 8.2.1 but failing in 8.3.0

@pravi Did you run migrations? runners_registration_token is a new field that has been added in 8.3.0.

Previous attempt by @vsizov in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1931

@pravi as @grzesiek mentioned it should not be a rails problem. Check your db migrations

@pravi I though current GitLab rails version is also one that debian has. Can we stay on current version if you have your problems solved because of db? cc @sytses

The problem I saw was not related to update to rails 4.2.5 and that problem is already fixed. So this update should be easy.

@dzaporozhets debian ruby team already updated rails to 4.2.5 (we always try to move to latest upstream release, unless it breaks something in the archive). When multiple packages are dependant on a library we use transitions (https://release.debian.org/transitions/) to make sure all dependencies work. Since only redmine was the rails app in the archive earlier and diaspora was still in experimental, we did not use transitions option. Since gitlab is not yet in the archive they did not check gitlab dependency requirement. Once gitlab enters archive, for any future rails update we will consider gitlab as well. I will push for using transitions for rails update.

You can see the current status of dependencies at http://debian.fosscommunity.in/status/?appname=gitlab (bookmark that link for reference)

You can also check http://debian.fosscommunity.in/compare/?appname=diaspora&appname=gitlab for the versions used by diaspora. If possible, try to update to the same version. If there is a good reason like #2821 (closed) we will ask diaspora to update their version. If either debian, diaspora or gitlab wants to move to a newer version, it is very likely the other two would benefit from the move as well.

And the db issue is solved after I dropped the database (I was trying to install 8.3.0 on the same machine where 8.2.1 was already present). That reminds me,I have to handle updates too (I already do it for diaspora package where I run migrations on update)..

@pravi ok please answer me next questions:

1. Do you need GitLab to be on rails 4.2.5 now to continue work?
2. We can not update gems to newest version every time someone release a new version. Will it be a problem in future?

@dzaporozhets 1. I have relaxed dependecy to ~> 4.2.4 which is enough to continue work. But it would be nice if gitlab also moves so its better tested. 2. Even though we like to update to latest upstream, when we do it, we test all reverse dependencies work. So I don't think it will be a problem. Only a subset of the gems are shared with diaspora, when only gitlab needs a gem, we are good with any version you choose for as long as it makes sense to you. Also since we have three rails apps (gitlab, diaspora, redmine) in the archive, we will not update as frequently as we used to before :)

Only 9 out of 251 gems (http://debian.fosscommunity.in/compare/?appname=diaspora&appname=gitlab) have mismatched versions.

@pravi ok thanks. I will schedule rails update to later milestone then. Good that gem versions wont be a problem

Milestone changed to 8.5

Title changed from consider updating rails to 4.2.5 to Update rails to 4.2.5

Reassigned to @jameslopez

already done https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2591

Assignee removed

Status changed to closed

@vsizov yup just realised after pulling!

mentioned in merge request !14785