When deleting branches through UI (remove source branch) causes double notifications

Deleting branches through UI ("Remove source branch") results in showing this operation twice in activity feed. Deleting branch using CLI (git push --delete ..., git push remote :branch) is counted only once, as expected.

Title changed from Deleting branches through UI or command line - activity feed count problem to When deleting branches through UI and command line activity feed is different

mentioned in issue #5611 (closed)

mentioned in issue #5892 (closed)

Milestone changed to 8.5

Added ~12980 label

Added ~131895 label

Title changed from When deleting branches through UI and command line activity feed is different to When deleting branches through UI (remove source branch) causes double notifications

mentioned in issue #5948 (closed)

This is reported quite often (closed 3 duplicates so far), so I think it is important to fix. \cc @dzaporozhets

It looks like this happens for both creation and deletion of branches through the UI. This is what is happening:

1. User deletes branch: DeleteBranchService calls EventCreateService and creates an event.
2. The call to repository.rm_branch triggers the GitHooksService.
3. This, in turn, calls GitPushService and then calls EventCreateService again.

I think 5145706c now makes it no longer necessary for DeleteBranchService and CreateBranchService to create an event.

mentioned in merge request !2343 (merged)

@grzesiek agree. Thanks for ping

@stanhu makes total sense. Thank you very much for fix!

mentioned in issue #5984 (closed)

Milestone changed to 8.3

Status changed to closed by commit 423d2d62

mentioned in commit 423d2d62

@stanhu, the duplicate activity view messages are gone but it looks like this same issue is causing duplicate web hooks. I'm currently on v8.3.4.

mentioned in merge request !14785