Commit message mentions don't work in first branch push

Summary

When pushing to a new branch the commit messages are not parsed for issue numbers/links.

Steps to reproduce

git checkout -b bugfix
git commit -m "This fixes issue #55"
git push -u origin bugfix

Expected behavior

Issue 55 should have a mention of the commit in it's activity feed

Possible fixes

The project's activity feed only shows an entry for pushing a new branch and no mention of the commit(s). I'm guessing the logic to check for commit mentions is only on pushing commit activities.

/cc: @razer6

I reproduced this to my surprise. It looks like it was intentional via 224e104d. I can see the performance downside of doing this on large commits, but it seems like it's useful to process commit messages for references.

Thoughts, @haynes, @DouweM?

@stanhu That commit affects only the case of the initial push to the default branch. New pushes to new branches after that should definitely have their commit messages processed. If this is not currently working, the issue is likely somewhere else.

Looking at the code at https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/services/git_push_service.rb#L47 it looks like it should be processing the commits for new branches.

My guess is @push_commits is not being populated correctly at.

When I push to a new branch the activity feed doesn't show any commits.

But when I push to an existing branch it does show commits.

@szechyjs Hmm, that does sound related. Both the activity feed event and commit message parsing use @push_commits, so if that's incorrectly populated, both would not work/be empty.

I'll schedule this for 8.5.

Milestone changed to 8.5

Added ~12980 label

Reassigned to @jameslopez

mentioned in merge request !2501 (closed)

mentioned in issue gitlab_git#15 (closed)

mentioned in merge request gitlab_git!61 (merged)

mentioned in merge request !2516 (merged)

Status changed to closed by commit 419a5e00

Status changed to closed by merge request !2516 (merged)

mentioned in commit 419a5e00

mentioned in commit 2d8b6901

mentioned in commit bf64752c

Mentioned in commit maxraab/gitlab-ce@bf64752c