There is a bug in GitLab where assigning a MR does not send a notification
@jacobvosmaer how can we replicate this?
cc @sytses
@rspeicher this is awful for workflow. If this is in stable, it warrants a patch.
Activity
mentioned in merge request gitlab-com/www-gitlab-com!1277 (closed)
mentioned in merge request rymai/dotfiles!1 (closed)
When trying to reproduce this issue locally on
master(1ede18bf) it seems to work well:- the initial assignee receives an email;
- if I update the assignee, both the former and the latter assignees receive a notification.
That said, the issue seems to exist on GitLab.com: I've tried updating the assignee on a private project and I never received a notification.
PS: It seems weird that a mention from a private project (rymai/dotfiles!1 (closed)) is mentioned here?
@rymai Please create a security issue for the leaking of the private project name
mentioned in issue #6066 (closed)
@sytses Sure, done!
That said, the issue seems to exist on GitLab.com: I've tried updating the assignee on a private project and I never received a notification.
Did you change the assignee to yourself? You never get a notification for changes you made yourself.
Did you change the assignee to yourself? You never get a notification for changes you made yourself.
@DouweM Yes, that's what I did and suspected indeed, because since then I received notification emails for other MRs which have had their assignee updated.
@JobV @jacobvosmaer I cannot reproduce, we should probably close this issue.
Reassigned to @jacobvosmaer
I think you need two accounts to check this behavior. One with working email notifications, and the participation level set to mention. Then using the second account, assign something to the first account.
The first account, with notification level 'mention', should be notified of the assignment. The bug is that they never get an email.
Look at the picture above. I got an email notification because @rymai mentioned me. But when he assigned the issue to me I received no email.
@rymai to answer your earlier suggestion: I think we should not close this issue. This is still broken as of 8.4.0.rc1-ee aad1ab3
@jacobvosmaer Thanks for the precise description of the problem, indeed it should not be closed!
@jacobvosmaer I see the issue in the code now.
So basically we should consider an assignation as a mention, in terms of notification behavior. Sounds good @JobV @DouweM @rspeicher @sytses?
If yes, I'll submit a MR today.
@rymai Yep, makes sense.
mentioned in merge request !2449 (merged)
@rymai I'm assigning this one to you since you're working on this
Reassigned to @rymai
Thanks @rdavila!
