Ugrade Guide: From 7.2 to 7.3: sed commando for backlog does not match

The Upgrade Guide say in 6. Update config files that we should run:

# Use the default Unicorn socket backlog value of 1024
sudo -u git -H sed -i 's|^:backlog => 64|:backlog => 1024|' config/unicorn.rb

If I understand that right this should change the line from

listen "/home/git/gitlab/tmp/sockets/gitlab.socket", :backlog => 64

to

listen "/home/git/gitlab/tmp/sockets/gitlab.socket", :backlog => 1024

but the sed commando will not match because the ^ will require that :backlog => 64 is at the beginning of the line. Instead

sudo -u git -H sed -i 's|:backlog => 64|:backlog => 1024|' config/unicorn.rb

will work.

Reassigned to @sytses

Reassigned to @jacobvosmaer

@jacobvosmaer Can you look into this?

He's absolutely right. I have encountered this problem as well.

listen "/home/git/gitlab/tmp/sockets/gitlab.socket", :backlog => 1024

is working.

This looks like a copy-paste error in the sed command; as @raabf said, the ^ should not be there.

Fixed with 475c554f

Status changed to closed

mentioned in merge request !14785