Skip to content

RSS feed does not include full urls to comments

Summary:

RSS feed does not include full urls to comments which results in a broken link if you subscribe to the feed.

Steps to reproduce:
  • Subscribe to your activity feed's RSS through your email
  • Comment on a Merge Request
  • View the email notification for the comment event
Expected behavior

The email body will include a full url (with the current host, port and path prefix) for the note event.

Observed behavior

The email body contains the URI but not the current host, port, and path prefix resulting in a broken link. Please see the attached image of the raw feed for additional information.

Screen Shot 2014-10-06 at 9.50.08 AM

Output of checks

Application Check passed GitLab Version 7.4.0-pre c0bb3f5a

Possible fixes:

In the app/helpers/event_helpers.rb file, the controller helpers must be changed from path to url for comments on commits (line 74 and 110 - line 70 is already using the correct helper), snippets (line 76), and else (line 112). Creating a Merge Request with my fix.