Slack integration stopped working

The recent change to the Slack integration on 7.4.0 broke it completely.

  - Changes to Slack service structure, only webhook url needed

Not only does the usability suffer as now you'll need to generate a new integration in Slack for each project / channel. Instead of just copypasting the one key to each project and typing in the channel. And change the icon and name for the Slack bot for each webhook.

But more importantly, it doesn't even work. I've created an incoming webhook in Slack:

And copy-pasted the unique webhook url to the project in GitLab, but neither the test button nor pushes to the project send any messages to Slack.

When clicking the test button, the only thing appearing to /home/git/gitlab/log/*.log is:

Started GET "/websites/opus/services/slack/test" for 127.0.0.1 at 2014-10-21 09:13:36 +0300
Processing by Projects::ServicesController#test as HTML
  Parameters: {"project_id"=>"websites/opus", "id"=>"slack"}
Redirected to http://projects.useful.fi/websites/opus/services/slack/edit
Completed 302 Found in 510ms (ActiveRecord: 3.1ms)
Started GET "/websites/opus/services/slack/edit" for 127.0.0.1 at 2014-10-21 09:13:37 +0300
Processing by Projects::ServicesController#edit as HTML
  Parameters: {"project_id"=>"websites/opus", "id"=>"slack"}
Completed 200 OK in 36ms (Views: 17.7ms | ActiveRecord: 3.5ms)

The changes were required for slack team to integrate GitLab as predefined integration. In any case you need to set the room on the slack side so setting it in 2 places makes no sense. The logo will change when Slack finalizes integration.

I cannot replicate this on 7.4.rc1, I have a successful test

Started GET "/gitlab-org/gitlab-ci/services/slack/test" for 127.0.0.1 at 2014-10-21 09:05:41 +0200
Processing by Projects::ServicesController#test as HTML
  Parameters: {"project_id"=>"gitlab-org/gitlab-ci", "id"=>"slack"}
  User Load (0.8ms)  SELECT  "users".* FROM "users"  WHERE "users"."id" = 1  ORDER BY "users"."id" ASC LIMIT 1

Any ideas on how I should debug this?

Couple of questions:

1. Where are you testing this, do you have your own instance and what is the version?
2. Since 10:00 CET gitlab.com is running 7.4.rc1 and using an incoming webhook https://TEAM.slack.com/services/hooks/incoming-webhook?token=TOKEN I successfully get notifications to slack room from gitlab.com project
3. Can you try your webhook url on a project on gitlab.com?
4. How does your hook look like (omit sensitive info)

1. Own Ubuntu server, manually installed before omnibus and upgraded to latest (7.4.0.rc1)

2. I'll try that soon...

3. https://our-team.slack.com/services/hooks/incoming-webhook?token=OURTOKEN

There's no test button in gitlab.com?

Yes there is

Did you save?

Yep. And refreshed. And hard-refreshed.

The webhook url is stored when I come back to the service settings and its got the green circle indicating its on.

I now tested pushing code to that repository on gitlab.com and didn't get any messages to Slack either.

One more note, the test button does appear on my own server, yet it doesn't work there. The problem of the non-existent test button is only on gitlab.com.

I may have found a problem related to the webhook url as now I am able to replicate the problem. The issue with missing test settings button I cannot replicate.

Should I give you access to the project here on gitlab.com so you can see for yourself?

Thanks for adding me, I see the test button: http://cl.ly/image/323T3o3c2r3x (i removed the url from the screenshot)

I also see it now. Some kind of cache problem?

Probably. Thanks for the report tho, I found the problem and it will be in the stable 7.4 release.

Here's how to replicate:

1. Create a new project
2. Goto Settings / Services / Slack
3. Click active and add url, then save
4. There is no Test button

That is expected behaviour, the repo is empty.

Oh, ok.

The problem comes from the subdomain with a dash?

"somethin-something.slack.com"?

The regex only matches /(\w*).slack.com.services/(.)/

Should probably be something like /([a-zA-Z0-9_-]+).slack.com.services/(.)/ instead?

For anyone wanting to patch this before the stable release:

diff --git a/app/models/project_services/slack_service.rb b/app/models/project_services/slack_service.rb
index 95f3ddc..030b5de 100644
--- a/app/models/project_services/slack_service.rb
+++ b/app/models/project_services/slack_service.rb
@@ -40,7 +40,7 @@ class SlackService < Service
       project_name: project_name
     ))

-    credentials = webhook.match(/(\w*).slack.com.*services\/(.*)/)
+    credentials = webhook.match(/([a-zA-Z0-9-]+).slack.com.*services\/(.*)/)
     if credentials.present?
       subdomain =  credentials[1]
       token = credentials[2].split("token=").last

Fixed with https://gitlab.com/gitlab-org/gitlab-ce/commit/fbe9b00fc9304f3e4a98192be99a7dce17ae08a0

Status changed to closed

I re-enabled room setting with the following patch: https://gist.github.com/mtorromeo/0fe22e5e8d2960aa45ba

@massimiliano.torromeo I don't get why would you even want to do that when the room setting is in slack services configuration:

Because I can set different rooms to different projects with the same webhook

I'm too going to patch this back. We have a ton of projects and I don't have the time to generate a new integration for each project / channel. It's much easier to just copy-paste the webhook url and type a channel.

Be warned that this will change even further in the next releases as the slack-notifier gem has been updated to use the new syntax Slack is introducing.

Are there any plans on making a Slack integration that would use more of their API? Something where the API keys or webhook url would have to be set only once on a group or global level and then just select a channel for each project?