Public snippet still needs authentication

Public snippets work exactly like internal snippets as the request for a snippet, when set/created to be public still needs authentication.
Public snippets should be actually public.

Example: https://gitlab.com/snippets/2203

I have the same issue, below is the output from production.log

Started GET "/snippets/16" for 127.0.0.1 at 2014-10-22 13:57:51 +0100
Processing by SnippetsController#show as HTML
  Parameters: {"id"=>"16"}
Completed 401 Unauthorized in 2ms
Started GET "/users/sign_in" for 127.0.0.1 at 2014-10-22 13:57:51 +0100
Processing by SessionsController#new as HTML
Completed 200 OK in 476ms (Views: 71.5ms | ActiveRecord: 3.5ms)
Started GET "/" for 127.0.0.1 at 2014-10-22 14:00:01 +0100
Processing by DashboardController#show as HTML
Completed 401 Unauthorized in 1ms

Reassigned to @vsizov

mentioned in issue #694 (closed)

Fixed as far as #694 (closed) specifies. Will check Friday at the most.

Status changed to closed

Ok not specified in #694 (closed), but it seems it should be fixed. Again will check in the coming days.

If I upgrade my server to 7.4 now this problem will be fixed? Or I need wait 7.4.1?

@rodrigo.avila, afaik, it's not fixed yet, we need the devs to update

Status changed to reopened

So further on this, when accessing the snippets, you can see a list of the public snippets (i.e. going to https://gitlab.com/snippets as an example), as see in the image below, but once you click the links, it asks you to log-in

Hi chaps,

Have just updated my installation to 7.4.1, that has indeed fixed the public snippets issue, But now if I click my name in the public snippets section, it lists all of my snippets. When I click the private/internal snippets, I can't view them, but nevertheless I shouldn't see that list. https://gitlab.com/gitlab-org/gitlab-ce/issues/704

Edited: It's the internal snippets are appearing, and they shouldn't

mentioned in issue #694 (closed)

Since 7.4.0 the title of newly created internal snippets is exposed to people who are not logged in. The contents of internal snippets is not exposed, and private snippets are not affected. We will fix this in 7.4.2 which will release today, October 24.

thanks, @vsizov, fixed in the latest 7.4.2 release, I have now tested this!! :)

One last issue I think with the public snippets ;)

The raw button is displayed, and pressing it asks you to go into signing in, not a major issue, but one nevertheless.

Do we want people to view the snippets raw format?

mentioned in issue #694 (closed)

we will look into this issue. Thanks @arif-ali

The raw button is displayed, and pressing it asks you to go into signing in, not a major issue, but one nevertheless.

Fixed by 40c8f159

I guess it's safe to close this then. Thanks all :)

Status changed to closed