LDAP Login Error on Config Format Change - EDIT
Hello,
When we try to sign in using 7.4 - instead of the sign-in page, we just get a 500 error.
Logs show the following:
ActionView::Template::Error (undefined local variable or method `provider' for #<#<Class:0x00000005b99790>:0x00000004e4bbb0>):
1: = form_tag(user_omniauth_callback_path(provider), id: 'new_ldap_user' ) do
2: = text_field_tag :username, nil, {class: "form-control top", placeholder: "LDAP Login", autofocus: "autofocus"}
3: = password_field_tag :password, nil, {class: "form-control bottom", placeholder: "Password"}
4: %br/
app/views/devise/sessions/_new_ldap.html.haml:1:in `_app_views_devise_sessions__new_ldap_html_haml__2354148892424314156_39962560'
app/views/devise/sessions/new.html.haml:20:in `_app_views_devise_sessions_new_html_haml___4367331346154162228_12397100'
app/controllers/sessions_controller.rb:25:in `new'Users who are already signed in don't have a problem as long as their session stays valid.
I've updated the config file to be in the new format, it looks like it should be ok:
## LDAP settings
ldap:
enabled: true
servers:
main:
label: 'LDAP'
host: '10.175.15.1'
base: 'dc=hosting,dc=example,dc=net'
port: 636
uid: 'uid'
method: 'ssl' # "ssl" or "plain"
bind_dn: ''
password: ''
allow_username_or_email_login: true
user_filter: ''
active_directory: falseEDIT: Hijacked the ticket for the other bug that was discovered, see later comment.
Activity
Thanks @Raphael_HBS - that seems to have worked.
Although is there a new trick to disable standard login if we only want LDAP enabled?
Also, with the new LDAP config format of servers -> main -> config, we get 500 errors when ever we try and push any code.
Log Entry:
Started GET "/rainbow/rainbow.git/info/refs?service=git-upload-pack" for ***.***.***.*** at 2014-10-21 13:34:50 +0100 ArgumentError (host,port,method,uid or filter,base MUST be provided): lib/gitlab/ldap/authentication.rb:45:in `new' lib/gitlab/ldap/authentication.rb:45:in `adapter' lib/gitlab/ldap/authentication.rb:37:in `login' lib/gitlab/ldap/authentication.rb:18:in `block in login' lib/gitlab/ldap/authentication.rb:16:in `each' lib/gitlab/ldap/authentication.rb:16:in `find' lib/gitlab/ldap/authentication.rb:16:in `login' lib/gitlab/auth.rb:12:in `find' lib/gitlab/backend/grack_auth.rb:76:in `authenticate_user' lib/gitlab/backend/grack_auth.rb:47:in `auth!' lib/gitlab/backend/grack_auth.rb:26:in `call' Started GET "/users/sign_in" for ***.***.***.*** at 2014-10-21 13:34:52 +0100 Processing by SessionsController#new as HTML Redirected to https://git.example.net/ Filter chain halted as :require_no_authentication rendered or redirected Completed 302 Found in 4ms (ActiveRecord: 1.0ms) Started GET "/" for ***.***.***.*** at 2014-10-21 13:34:52 +0100 Processing by DashboardController#show as HTML Completed 500 Internal Server Error in 3ms RuntimeError (Unknown provider (ldap). Available providers: ["ldapmain"]): lib/gitlab/ldap/config.rb:97:in `invalid_provider' lib/gitlab/ldap/config.rb:21:in `initialize' lib/gitlab/ldap/adapter.rb:13:in `new' lib/gitlab/ldap/adapter.rb:13:in `config' lib/gitlab/ldap/adapter.rb:7:in `open' lib/gitlab/ldap/access.rb:11:in `open' lib/gitlab/ldap/access.rb:17:in `allowed?' app/controllers/application_controller.rb:204:in `ldap_security_check'On rolling back to the old format (which works great), I had to go into the database to fix a problem with my user.
It appears the provider field in the users table has updated from ldap to ldapmain for the users who have logged out and back into the web interface - but there sessions weren't forced to end, so hardly anyone has.
Plus when doing a push, it doesn't apply this user fix - so until everyone's user is updated via logging into the web interface, they can no longer push.
Duplicate of https://github.com/gitlabhq/gitlabhq/issues/8129
@razer6 What about the issue highlighted in the comment above about the config format change re "ldap"/"ldapmain" provider error when trying to push?
