7.4: error when viewing the contents of a directory

This seems to be the same problem as github issue 8135. There's a pending merge request at gitlab_git!9 (merged) to fix the gitlab_git gem's submodule handling.

Fixed in 7.4.1

Status changed to closed

Still have the exact same issue with 7.4.2 it seems:

Started GET "/brightfish/touch/tree/master/BrightfishTouch" for 127.0.0.1 at 2014-10-25 15:19:25 +0200
Processing by Projects::TreeController#show as HTML
  Parameters: {"project_id"=>"brightfish/touch", "id"=>"master/BrightfishTouch"}
Completed 500 Internal Server Error in 447ms

ActionView::Template::Error (undefined method `[]' for nil:NilClass):
    1: - tree, commit = submodule_links(submodule_item)
    2: %tr{ class: "tree-item" }
    3:   %td.tree-item-file-name
    4:     %i.fa.fa-archive
  app/models/repository.rb:162:in `method_missing'
  app/models/repository.rb:228:in `submodule_url_for'
  app/helpers/submodule_helper.rb:6:in `submodule_links'
  app/views/projects/tree/_submodule_item.html.haml:1:in `_app_views_projects_tree__submodule_item_html_haml___3047811747770310914_44909780'
  app/helpers/tree_helper.rb:19:in `render_tree'
  app/views/projects/tree/_tree.html.haml:42:in `_app_views_projects_tree__tree_html_haml___1492498186045871714_26650420'
  app/views/projects/tree/show.html.haml:9:in `_app_views_projects_tree_show_html_haml___1722179341001896197_28555860'
  app/controllers/projects/tree_controller.rb:13:in `show'


Started GET "/brightfish/touch/tree/master/BrightfishTouch" for 127.0.0.1 at 2014-10-25 15:19:26 +0200
Processing by Projects::TreeController#show as HTML
  Parameters: {"project_id"=>"brightfish/touch", "id"=>"master/BrightfishTouch"}
Completed 500 Internal Server Error in 483ms

ActionView::Template::Error (undefined method `[]' for nil:NilClass):
    1: - tree, commit = submodule_links(submodule_item)
    2: %tr{ class: "tree-item" }
    3:   %td.tree-item-file-name
    4:     %i.fa.fa-archive
  app/models/repository.rb:162:in `method_missing'
  app/models/repository.rb:228:in `submodule_url_for'
  app/helpers/submodule_helper.rb:6:in `submodule_links'
  app/views/projects/tree/_submodule_item.html.haml:1:in `_app_views_projects_tree__submodule_item_html_haml___3047811747770310914_44909780'
  app/helpers/tree_helper.rb:19:in `render_tree'
  app/views/projects/tree/_tree.html.haml:42:in `_app_views_projects_tree__tree_html_haml___1492498186045871714_26650420'
  app/views/projects/tree/show.html.haml:9:in `_app_views_projects_tree_show_html_haml___1722179341001896197_28555860'
  app/controllers/projects/tree_controller.rb:13:in `show'

System info:

System information
System:		Debian 7.7
Current User:	git
Using RVM:	no
Ruby Version:	2.1.3p242
Gem Version:	2.2.2
Bundler Version:1.7.4
Rake Version:	10.3.2
Sidekiq Version:2.17.0

GitLab information
Version:	7.4.2
Revision:	477743a
Directory:	/var/git/gitlab
DB Adapter:	mysql2
URL:		http://gitlab
HTTP Clone URL:	http://gitlab/some-project.git
SSH Clone URL:	git@gitlab:some-project.git
Using LDAP:	no
Using Omniauth:	no

GitLab Shell
Version:	2.1.0
Repositories:	/var/git/repositories/
Hooks:		/var/git/gitlab-shell/hooks/
Git:		/usr/bin/git

Status changed to reopened

I'm having trouble reproducing this in 7.4.2. @nikki-auburger is there any chance the GitLab server didn't get restarted after upgrading to 7.4.2?

Also, I think someone mentioned in another issue that gitlab-shell 2.1.0 isn't supported in GitLab 7.4.x. That probably isn't causing this problem, but it might give you trouble in other parts of the app.

I tried restarting Gitlab more thoroughly after my first attempt, and made sure that no processes were left. The admin panel reports the correct version.

I also ran into the problem with gitlab-shell 2.1.0 when trying to fetch over ssh, so I reverted it back to 2.0.1 but as you suspected it was unrelated to the reported problem.

Is there any debugging info I can get you @mr-vinn ?

My best guess is that you're either not getting the right version of gitlab_git somehow, or that there's something distinct about your repo that trips up gitlab_git's submodule handling. Starting with the first option, can you post the output of bundle show gitlab_git?

Can you also post the contents of your repo's .submodules file (if there's no sensitive data contained in it)? The gitlab_git gem parses that file to get submodule information, so it might help to see what's in there.

The first is /var/git/gitlab/vendor/bundle/ruby/2.1.0/gems/gitlab_git-7.0.0.rc10

The .gitmodules file:

[submodule "BrightfishTouch/cocos2d/3.1git"]
	path = BrightfishTouch/cocos2d/3.1git
	url = git://github.com/cocos2d/cocos2d-iphone.git
[submodule "BrightfishTouch/CocoaAsyncSocket"]
	path = BrightfishTouch/CocoaAsyncSocket
	url = https://github.com/ChatSecure/CocoaAsyncSocket.git
[submodule "BrightfishTouch/dtrte"]
	path = BrightfishTouch/dtrte
	url = git@git.cocoanetics.com:parts/dtrichtexteditor.git
[submodule "BrightfishTouch/GPUImage"]
	path = BrightfishTouch/GPUImage
url=https://github.com/demon1105/GPUImage.git
[submodule "BrightfishTouch/Reachability"]
	path = BrightfishTouch/Reachability
	url = https://github.com/tonymillion/Reachability.git

Oh, I think I see it - gitlab_git expects a space before and after the equal sign, and the entry for "BrightfishTouch/GPUImage" doesn't have them. I'll submit a patch to gitlab_git to handle that correctly; you should be able to work around it in the meantime by adding spaces to the url line of that submodule.

mentioned in merge request !11 (merged)

@mr-vinn Is there something wrong with the cross-project referencing?

It looks like the underscore in "gitlab_git" is confusing the Markdown parser. Underscores in the "mentioned in..." string probably need to be escaped, they would have never been there in same-project references.

@mr-vinn adding the whitespace fixed the problem indeed, thanks.

mentioned in merge request !227 (merged)

@mr-vinn Do you have any idea when your fix will be included in a release? The workaround (fixing the whitespace) works, but I will have to merge the changed .gitmodules file into all open branches if it's going to be of any practical use :)

Pending MR: gitlab_git!11 (merged)

@nikki-auburger it will probably be released in next 7.5 version.

mentioned in issue #760 (closed)

I have applied the patch in gitlab_git!11 (merged) but it does not seem to work for me (I have restarted the gitlab service of course). I also fixed the .gitmodules file indentation but nothing changed. Is that information about submodules is cached somehow or it's get parsed again on every page load? How can I clear the cache?

mentioned in commit 1f476c9f

Ohhh I think I found it what's wrong in my case. I have a .gitmodules file which contains invalid paths. A path which is actually not exists in the repo and the code at line https://gitlab.com/gitlab-org/gitlab_git/blob/master/lib/gitlab_git/repository.rb#L747 fails and the other entries on .gitmodules will not be parsed. So I think we should add a check there if the path actually exist in the git repo (and contains the commit hash) or not. Could somebody fix that too please (I don't know ruby well enough)?

I have created an example repo https://gitlab.com/1ed/a/tree/master and a .gitmodules file https://gitlab.com/1ed/a/blob/master/.gitmodules .

I have a similar issue, #775 (closed) "Viewing files fails with 500 error for forked project having relative submodule URLs". I thought it had to do with the fact that I have relative submodule URLs. They should resolve correctly to existing projects in GitLab in the same namespace, but for some reason I get a 500 error instead.

mentioned in issue #333 (closed)

mentioned in merge request !14 (merged)

mentioned in commit d6c3928e

MR merged, so close this issue

Status changed to closed

I'm still having this issue in 7.5.3 and none of the workarounds or other mentions that I can find fix it. We have a repo with probably 50 submodules, most of which are on GitHub. There's no odd whitespacing, etc. Here's the modules file.

[submodule "modules/mcollective/files/puppetlabs-mcollective-plugins"]
  path = modules/mcollective/files/puppetlabs-mcollective-plugins
  url = git://github.com/puppetlabs/mcollective-plugins.git
[submodule "modules/puppet/files/puppet-git-hooks"]
  path = modules/puppet/files/puppet-git-hooks
  url = git://github.com/buckle/puppet-git-hooks.git
[submodule "modules/firewall"]
	path = modules/firewall
	url = git://github.com/buckle/puppetlabs-firewall.git
[submodule "modules/concat"]
	path = modules/concat
	url = git://github.com/ripienaar/puppet-concat.git
[submodule "modules/profile_d"]
	path = modules/profile_d
	url = git://github.com/buckle/puppet-profile_d.git
[submodule "modules/puppetdb"]
	path = modules/puppetdb
	url = https://github.com/buckle/puppetlabs-puppetdb
[submodule "modules/stdlib"]
	path = modules/stdlib
	url = https://github.com/puppetlabs/puppetlabs-stdlib
[submodule "modules/inifile"]
	path = modules/inifile
	url = https://github.com/cprice-puppet/puppetlabs-inifile
[submodule "modules/postgresql"]
	path = modules/postgresql
	url = https://github.com/puppetlabs/puppet-postgresql
[submodule "modules/mysql"]
	path = modules/mysql
	url = git://github.com/buckle/puppetlabs-mysql.git
[submodule "modules/apache"]
	path = modules/apache
	url = git://github.com/buckle/puppet-apache.git
[submodule "modules/vcsrepo"]
	path = modules/vcsrepo
	url = git://github.com/puppetlabs/puppetlabs-vcsrepo.git
[submodule "modules/jenkins"]
	path = modules/jenkins
	url = git://github.com/jenkinsci/puppet-jenkins.git
[submodule "modules/tomcat"]
	path = modules/tomcat
	url = git://github.com/buckle/puppet-tomcat.git
[submodule "modules/nginx"]
	path = modules/nginx
	url = git://github.com/buckle/puppetlabs-nginx
[submodule "modules/graphite"]
	path = modules/graphite
	url = git://github.com/buckle/puppet-graphite
[submodule "modules/logstash"]
	path = modules/logstash
	url = git://github.com/elasticsearch/puppet-logstash
[submodule "modules/haproxy"]
	path = modules/haproxy
	url = git://github.com/buckle/puppetlabs-haproxy.git
[submodule "modules/rvm"]
	path = modules/rvm
	url = git://github.com/buckle/puppet-rvm.git
[submodule "modules/datacat"]
	path = modules/datacat
	url = https://github.com/richardc/puppet-datacat.git
[submodule "modules/rbenv"]
	path = modules/rbenv
	url = https://github.com/alup/puppet-rbenv
[submodule "modules/tftp"]
	path = modules/tftp
	url = git://github.com/buckle/puppet-tftp
[submodule "modules/bundler"]
	path = modules/bundler
	url = https://github.com/example42/puppet-bundler
[submodule "modules/puppi"]
	path = modules/puppi
	url = https://github.com/example42/puppi
[submodule "modules/file_concat"]
	path = modules/file_concat
	url = git://github.com/electrical/puppet-lib-file_concat.git
[submodule "modules/logrotate"]
	path = modules/logrotate
	url = https://github.com/rodjek/puppet-logrotate
[submodule "modules/elasticsearch"]
	path = modules/elasticsearch
	url = https://github.com/elasticsearch/puppet-elasticsearch
[submodule "modules/boolean"]
	path = modules/boolean
	url = https://github.com/adrienthebo/puppet-boolean
[submodule "modules/vsftpd"]
	path = modules/vsftpd
	url = https://github.com/thias/puppet-vsftpd.git
[submodule "modules/rabbitmq"]
	path = modules/rabbitmq
	url = https://github.com/puppetlabs/puppetlabs-rabbitmq
[submodule "modules/erlang"]
	path = modules/erlang
	url = https://github.com/garethr/garethr-erlang
[submodule "modules/staging"]
	path = modules/staging
	url = https://github.com/nanliu/puppet-staging
[submodule "modules/mariadb"]
	path = modules/mariadb
	url = https://github.com/NeCTAR-RC/puppet-mariadb.git
[submodule "modules/f5"]
	path = modules/f5
	url = https://github.com/dblessing/puppetlabs-f5
[submodule "modules/xtrabackup"]
	path = modules/xtrabackup
	url = https://github.com/BashtonLtd/puppet-xtrabackup.git
[submodule "modules/network"]
	path = modules/network
	url = https://github.com/dblessing/puppet-network
[submodule "modules/filemapper"]
	path = modules/filemapper
	url = https://github.com/adrienthebo/puppet-filemapper
[submodule "modules/consul"]
	path = modules/consul
	url = https://github.com/solarkennedy/puppet-consul
[submodule "modules/gitlab"]
	path = modules/gitlab
	url = https://github.com/spuder/puppet-gitlab.git

The fix is not included in 7.5... we have to wait until 7.6 or later... I don't know. There is a test repo for the same issue here https://gitlab.com/1ed/a/tree/master

@dblessing The workaround would be to remove all invalid entries from the .gitmodules file. Remove every submodule block which is not listed by the git submodule command (and add them back properly with git submodule add if they are actually required).

Thanks for the tips. I found out it was because there were 2 entries in submodules that were no longer actual submodules. Thanks for telling me about git submodule printing a list of submodules, @1ed. That's what led me to fixing this.

@dblessing so you aren't having any difficulties with the git://githbub... submodules? I have been using git@mygitlab.... and trying to find a fix. (gitlab 7.5.1)

I have a same issue in GitLab 7.5.3 Is this Fixed? What version do I need to Upgrade?

I have the same issue in GitLab 7.6.2 (16f0968c).

Started GET "/group/project/tree/master/code/assets" for 115.193.185.242 at 2015-01-30 11:57:31 +0800 Processing by Projects::TreeController#show as HTML Parameters: {"project_id"=>"group/project", "id"=>"master/code/assets"} Completed 500 Internal Server Error in 42ms ActionView::Template::Error (undefined method []' for nil:NilClass): 1: - tree, commit = submodule_links(submodule_item) 2: %tr{ class: "tree-item" } 3: %td.tree-item-file-name 4: %i.fa.fa-archive app/models/repository.rb:162:in method_missing' app/models/repository.rb:228:in submodule_url_for' app/helpers/submodule_helper.rb:6:in submodule_links' app/views/projects/tree/_submodule_item.html.haml:1:in _app_views_projects_tree__submodule_item_html_haml__2987383358709336182_43582260' app/helpers/tree_helper.rb:19:in render_tree' app/views/projects/tree/_tree.html.haml:42:in _app_views_projects_tree__tree_html_haml__3504342934442672941_55647920' app/views/projects/tree/show.html.haml:9:in _app_views_projects_tree_show_html_haml__3055756981333607012_39658000' app/controllers/projects/tree_controller.rb:13:in `show'

How can I fixed this problem without upgraded? Such as modifing some 'wrong' files?

Ok, I remove the submodule in my second level tree, and it works fine.
To find the submodules, use:

git ls-files --stage | grep 160000
And then delete it :
git rm --cached path/toyour/submodule
And commit and push.

Also see : https://github.com/gitlabhq/gitlabhq/issues/8135

Thanks @jiacheo - the same fix worked for me. (I actually just had a leftover empty dir which had this 160000 thingy.)

I got the same error. In my case, .gitmodules has comment lines:

[submodule "lib/foo.git"]
  path = lib/foo.git
  url = http://localhost/foo.git
# [submodule "lib/bar.git"]
#   path = lib/bar.git
#   url = http://localhost/bar.git

On GitLab 7.9.1.

Same error on 7.11.4, update from manual download.

7.4: error when viewing the contents of a directory

Designs

Child items 0

Activity

Admin message

Admin message

7.4: error when viewing the contents of a directory

Activity