Implement a new build view
Orginal comment: https://gitlab.com/gitlab-org/gitlab-ce/issues/2932#note_2647887
Here's what I see as the intentional changes:
- Improve job bar (color icons, upcasing, pipe separator)
- Improve status and build meta info (combine into single line, under job bar)
- Improve pull commit message to section above output (instead of sidebar)
- Remove redundant meta info from sidebar (build # and other builds)
- Improve colors of job output
- Overall color/layout around the borders
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Kamil Trzcińśki Milestone changed to 8.5
Milestone changed to 8.5
- Kamil Trzcińśki mentioned in issue #2932 (closed)
mentioned in issue #2932 (closed)
- Kamil Trzcińśki mentioned in issue #4263 (closed)
mentioned in issue #4263 (closed)
- username-removed-444 Added frontend label
Added frontend label
- Grzegorz Bizon Added ~19173 label
Added ~19173 label
- username-removed-347329 mentioned in issue #12776 (moved)
mentioned in issue #12776 (moved)
- username-removed-444 Milestone changed to 8.6
Milestone changed to 8.6
- Contributor
I'm not sure how much you're planning on re-designing, but there are features in the Travis CI build output that I really like:
- Section / task "folding" - Only important info (build output) are shown, while Git clone, Docker pull, etc. hidden by default.
-
Section / task labeling - As seen on the right side, this tells which part of the
.travis-ci.yml
is running - Section / task timing - Also as seen on the right side, the amount of time each part took to execute
- Linkable line numbers - Sometimes it's nice to be able to send someone a link directly to a line in the build output.
(From https://travis-ci.org/JonathonReinhart/scuba/jobs/107068716)
I can post a separate issue if it would make sense.
Edited by username-removed-90962 - Maintainer
@jonathon-reinhart That are very nice features! I think that adding permalinks to each line in build trace is a good beginning. What do you think @ayufan?
Edited by Grzegorz Bizon - Grzegorz Bizon mentioned in issue #13205 (moved)
mentioned in issue #13205 (moved)
- Maintainer
Maybe downloading a raw log would be also something useful, what do you think @jonathon-reinhart?
- Author Maintainer
In my old fork of GitLab CI I did port the Travis-CI build log with all of it's features: lines, and folding: https://github.com/ayufan/gitlab-ci/blob/topic/ci/lib/ansi2html.rb#L86 We could think about reusing that :)
- Author Maintainer
@grzesiek Ideally we should download raw trace in client and render everything with javascript :)
- Kamil Trzcińśki mentioned in issue #13559 (closed)
mentioned in issue #13559 (closed)
- username-removed-444 Milestone changed to 8.8
Milestone changed to 8.8
- Kamil Trzcińśki mentioned in issue #14717 (closed)
mentioned in issue #14717 (closed)
- Kamil Trzcińśki mentioned in issue #15598 (closed)
mentioned in issue #15598 (closed)
- Kamil Trzcińśki mentioned in issue #17686 (closed)
mentioned in issue #17686 (closed)
- Mark Pundsack Milestone changed to 8.10
Milestone changed to 8.10
- Mark Pundsack Milestone changed to 8.9
Milestone changed to 8.9
- Developer
- Maintainer
@ayufan @markpundsack we most likely will have time. If we get pinged sooner rather than later.
- Author Maintainer
@jschatz1 This is something that were already started by @iamphill: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3829
- Developer
There are so many changes in that screenshot, it's hard to know what's covered by this issue. For example, I assume the changes to the left sidebar are orthogonal to this issue and just represent an intermediate state of icon development.
Here's what I see as the intentional changes:
- Job bar (color icons, upcasing, pipe separator)
- Combining status and build meta info into single line, under job bar
- Pull commit message to section above output (instead of sidebar)
- Remove redundant meta info from sidebar (build # and other builds)
- Colors of job output
- Overall color/layout around the borders
- Developer
With our release of Pipelines, and the Atlassian and Jenkins announcing their own pipelines UIs, I can't help but wonder if we should use a pipelines view here as well. The example above has all of the jobs in a single stage, so it's not a good example to highlight pipelines.
Jenkins' Blue Ocean announcement looks like a pretty good interpretation of pipeline visuals. The pipeline takes up too much vertical space in those screenshots, but it's clean.
- Developer
FWIW, I like @jonathon-reinhart's suggestions for Travis-style features. I'm not sure we currently have the data to handle all of it.
- Developer
@jschatz1 Can we get !3829 (merged) merged without waiting on the rest of the items in this mockup? The changes in !3829 (merged) already look like a great improvement. In fact, the only piece untouched is the job bar (1) which I'd be happy to drop in favor of re-thinking in terms of Pipelines.
- Mark Pundsack mentioned in issue #18141 (closed)
mentioned in issue #18141 (closed)
- Mark Pundsack mentioned in issue #14664 (moved)
mentioned in issue #14664 (moved)
- Developer
Moved pipeline rendering discussion to https://gitlab.com/gitlab-org/gitlab-ce/issues/18141.
Created https://gitlab.com/gitlab-org/gitlab-ce/issues/18144 for linkable log lines.Already issue for linkable log lines (https://gitlab.com/gitlab-org/gitlab-ce/issues/13205).There's already an issue for collapsing the build log into sections (#14664 (moved)). I copied @jonathon-reinhart's comments there.
Edited by Mark Pundsack - Maintainer
@markpundsack that screenshot looks old and out of date . I could be wrong though.
Edited by Jacob Schatz - Maintainer
@iamphill @markpundsack reviewed. Will merged once fixed up.
- Mark Pundsack mentioned in issue #18249 (closed)
mentioned in issue #18249 (closed)
- Mark Pundsack Added ~15078 label
Added ~15078 label
- username-removed-90962 mentioned in issue #18664 (closed)
mentioned in issue #18664 (closed)
- Mark Pundsack Removed ~15078 label
Removed ~15078 label
- Douwe Maan Removed ~19173 frontend labels
Removed ~19173 frontend labels
- Douwe Maan Milestone changed to %8.10
Milestone changed to %8.10
- Douwe Maan Added ~19173 frontend labels
Added ~19173 frontend labels
- Developer
A bunch of changes were shipped in 8.9, and other issues were updated with comments for the rest. I don't think there's anything left in this issue, so I'm closing it.
- Mark Pundsack Status changed to closed
Status changed to closed
- Felipe Artur mentioned in issue gitlab#4215
mentioned in issue gitlab#4215