Avoid newbie pushes "Comment & close" button for discarding draft

Some user mis-pushes the Comment & Close for that purpose.

Perhaps have a Cancel button to discard draft.

OR

OR

Added feature proposal label

@JobV @dzaporozhets @creamzy thoughts?

Title changed from Feature: Cancel comment to Cancel comment

@axil this action can be misleading, as it can be treated in relation to an issue/ MR (like an action that can be done to an issue/MR).

But I understand your pain, we have no cleaning functionality in any of our search or filtering fields. In general I am not sure if we need it, but on the other hand because we don't clean the field automatically, let's collect opinions.

Let's think about other wording, like Discard draft

@creamzy agreed :)

The discard draft button looks nice but you could do the same choosing the text with Ctrl+A and then delete. I guess it boils down to how much of a lazy person you are :)

@axil Not just lazy. Some one mis-understood the Comment & close and pushed that wrong button. See https://gitlab.com/tortoisegit/tortoisegit/issues/2675#note_3023900

I guess the background colors of "Add Comment"/"Comment & close" are not that good. Perhaps not using contrasting colors.

Discard draft is OK for me.

@YueLinHo what do you mean under

I guess the background colors of "Add Comment"/"Comment & close" are not that good. Perhaps not using contrasting colors.

are you a colour blinded person, or you would prefer to have font weight bigger? I have suggested to have comment and close on the right-handside of the form, before another button was introduced. This is still possible, but it's a different issue. So you're free to create it.

I see the problem. We could get away with it by just adding more text, so that close becomes close issue.

@axil i do believe we have it on dev.gitlab.com.

I like @creamzy's design

Milestone changed to 8.6

@YueLinHo what do you mean under

I guess the background colors of "Add Comment"/"Comment & close" are not that good. Perhaps not using contrasting colors.

are you a colour blinded person, or you would prefer to have font weight bigger? I have suggested to have comment and close on the right-handside of the form, before another button was introduced. This is still possible, but it's a different issue. So you're free to create it.

@creamzy I am not a colour blinded person. That's just my guessing which using contrasting colors seem drop me a hint that one is "Add comment" and the other one is some opposite thing like "discard draft". And maybe the bad hint is not from word or color, but layout. So, have comment and close on the right-handside of the form maybe a good idea!!! But, I am not going to create a new issue, I am going to edit the issue.

To be honest, my first time pushing wrong button is on GitHub, not GitLab. And I have learned to use Ctrl+A & Delete after then. I just recalled someone get into the same issue on GitLab, then created this issue. /cc @TurkeyMan)

About Discard draft, I got one idea that using icon, something like this: (It's from GMail)

Title changed from Cancel comment to Avoid newbie pushes "Comment & close" button for discarding draft

You're right, it was me! ;)

I love the proposals at the top of this issue. I think that will solve the problem nicely. My personal favourite is the rubbish bin, since it's pretty conventional. If I saw the rubbish bin there, I would never accidentally click the other button assuming it means the same thing.

The problem was summarised above, I see "Post comment", and without any further reading or thought, the assumption is that the only other button is the inverse "Don't post comment", so you click it and accidentally post the comment anyway, and also close the issue... not what the user intended!

This has happened in my office a lot!

Added ~19492 label

I am against having comment and close on the right side of the form. I use comment+close often while discard almost never. I prefer @creamzy design from https://gitlab.com/gitlab-org/gitlab-ce/issues/8057#note_3204538

All the negative/revoking actions are on the right side (ex. when editing , it's cancel), so for this case Discard Draft should be on the right as well. It is just an issue of consistency. In a while you will adjust to consistent action placement.

Comment and close is not negative. Plus again we have Close Issue verbiage on dev. Maybe we can apply it to Comment & close issue as well? @dzaporozhets

Using icon instead of verbiage is open for vote @JobV @dzaporozhets @DouweM . Personally I prefer wording.

Comment & close issue

@creamzy good for me

Using icon instead of verbiage is open for vote

I prefer wording too

Please keep in mind:

• New naming for button Close
• Dependancy between state of comment field and Close issue / Comment& close issue button
• Dependancy between state of comment field and Discard draft btn presence

There is something is Comment field

Comment field is empty

Added frontend and removed ~19492 labels

All the negative/revoking actions are on the right side. [...] It is just an issue of consistency.

@creamzy Consistency is a nice reason!

Reassigned to @jschatz1

Reassigned to @iamphill

mentioned in commit e033b9a7

mentioned in merge request !3085 (merged)

Status changed to closed by merge request !3085 (merged)

mentioned in commit d343c7a1

Thanks for all of your work!