Award emoji window cannot be closed unless an emoji is chosen

Steps to reproduce:

1. Click the emoji button
2. Click outside the area or the button again

Doing any of the above should close the emoji window.

cc @vsizov @jschatz1

@axil can you please provide some browser info? I can't reproduce with Google Chrome 47.0.2526.111 in OS X 10.11.3

Pff, it's firefox again, chromium works fine :/

Arch Linux / Firefox 43.0.4

@tmaczukin can you check if this happens to you too?

Added ~145894 label

Yes, I can confirm.

Debian Linux / Firefox (Iceweasel) 39.0

In browser console there is an error: ReferenceError: event is not defined. It points to this code:

      $("html").click(function() {
        if (!$(event.target).closest(".emoji-menu").length) {
          if ($(".emoji-menu").is(":visible")) {
            return $(".emoji-menu").hide();
          }
        }
      });

the problem is in !$(event.target). I've searched sources and it's generated by this coffeescript: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/awards_handler.coffee#L9

I have a MR in for that @tmaczukin !2452 (merged) Same solution. @axil @rdavila Once that is merged it should solve this.

Yes, that MR is a proper fix. event variable is not set at all. How did Chrome work? :)

I noticed that Chrome predicts common developer's error and just works. It's not first time already.

@jschatz1 I close this one since it's fixed by !2452 (merged). ;)

Status changed to closed