Colors unclear in diff, maybe only for color blind people
When reviewing the Changes file in the web UI, deletions are highlighted in light red, and additions are highlighted in light green. Furthermore, wherever the cursor happens to be, that line is also highlighted in what appears to the colorblind eye to be red. As a color blind person, I am constantly being confused by thinking that the line that my cursor is on is a deletion.
Can we use a color scheme that is more clear? Or, can we move to a non-color based cursor-position indicator? \cc @lukebabb @skyruler @creamzy
Activity
@ernstvn we use not only color coding, but also show + / - for additions/deletions. The problem may be because these symbols don't really have a separate column to be visually distinguished, like in the screenshot below:
Screen_Shot_2016-01-17_at_20.47.46
I will double check the highlighted lines, thank you for the notice!
-
@JobV I add 8.5 milestone, if you're ok with it . It does not require a lot of work, but it is quite vital check.
Milestone changed to 8.5
@creamzy you'll look for a good solution in 8.5, you mean?
I'm fine with it ;)
-
@JobV yeah, so 8.5 it is.
-
Related #4271 (closed)
Reassigned to @creamzy
-
Related #13500 (closed)
As for the hover color I suggest to use #f4f8fe like in #12453 (closed) because blue is the most 'stable' color for most types of colourblindness (that is why Facebook is blue)
Added frontend label
Milestone changed to 8.6
I will use colors from #13500 (closed) although is tagged with the 8.7 milestone
This is essentially duplicate of https://gitlab.com/gitlab-org/gitlab-ce/issues/13500
